replace batch of redundant to_native()/to_text() occurrences

[russoz]

SUMMARY

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

plugins/modules/filesize.py
plugins/modules/flatpak_remote.py
plugins/modules/hg.py
plugins/modules/ip_netns.py
plugins/modules/ipa_pwpolicy.py
plugins/modules/iso_customize.py
plugins/modules/ldap_search.py
plugins/modules/nomad_job.py
plugins/modules/nosh.py
plugins/modules/ocapi_command.py
plugins/modules/ocapi_info.py
plugins/modules/packet_project.py
plugins/modules/packet_volume.py
plugins/modules/portage.py
plugins/modules/redhat_subscription.py
plugins/modules/snap.py
plugins/modules/xml.py

[ansibullbot]

cc @Akasurde @JayKayy @Nosmoht @Tatsh @ZouYuhua @adralioh @angristan @apecnascimento @bregman-arie @chris93111 @cmprescott @cnsnyder @dagwieers @eryx12o45 @jtyr @justchris1 @mikemoerk @nurfet-becirevic @oolongbrothers @ptoscano @quidame @sm4rk0 @t0mk @tacatac @tbielawa @vcarceler @wltjr @yeukhon
click here for bot help

[ptoscano]

@russoz the changes in redhat_subscription seems fine; that said, there are more occurrences in that file that can be removed, i.e. all of them except the one in subscribe_by_pool_ids().

[russoz]

@russoz the changes in redhat_subscription seems fine; that said, there are more occurrences in that file that can be removed, i.e. all of them except the one in subscribe_by_pool_ids().

Thanks for reviewing @ptoscano ! I think the one in subscribe_by_pool_ids() can be replaced with str(). WDYT?

[ptoscano]

I think the one in subscribe_by_pool_ids() can be replaced with str(). WDYT?

That is part of the pool management code of the module, which is tied to the entitlement mode for content access, which has been long deprecated by Red Hat, and on its way out of being supported. So I recommend to keep that code as-is, and I'll likely think about deprecating (with the goal to remove) the subscriptions management part.

Leaving one instance of to_native() around for now should not be a problem, should it?

[russoz]

No problem at all! Thanks for taking a look into it though!

[russoz]

please merge after #11105

[ptoscano]

The changes in plugins/modules/redhat_subscription.py LGTM.

[patchback]

Backport to stable-12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-12/f785e9c7803dc7194e8f44ed441bb330ba127147/pr-11106

Backported as #11140

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[felixfontein]

@russoz thanks for your contribution!
@ptoscano thanks for reviewing!