Extend failure message for merge_variables type detection #11107
Conversation
ansibullbot
added
bug
russoz
left a comment
russoz
left a comment
There was a problem hiding this comment.
Hi @rlenferink Thank you for the contribution! Please add a changelog fragment.
|
Without splitting semantic hairs, for our processes this is neither a Documentation (it actually changes the code behaviour) nor a Bug fix (it is not fixing something that was promised and not delivered), this is actually a new Feature. Just for the record. |
Update the error message for the merge_variables lookup plugin in case an unsupported type is passed.
|
Hi @russoz ! Thanks for reviewing! I have just added a changelog fragment for this. Also thanks for explaining the rationale on how the change is seen (docs vs bugfix vs new feature). I was indeed unsure about this; so with that in mind I picked the |
felixfontein
added
check-before-release
alpex8
left a comment
alpex8
left a comment
There was a problem hiding this comment.
Good improvement, thanks!
Backport to stable-12: 💚 backport PR created✅ Backport PR branch: Backported as #11166 🤖 @patchback |
felixfontein
removed
the
check-before-release
merge_variables: extend type detection failure message Update the error message for the merge_variables lookup plugin in case an unsupported type is passed. (cherry picked from commit e20e32b)
|
@rlenferink thanks for your contribution! |
…llections#11107) merge_variables: extend type detection failure message Update the error message for the merge_variables lookup plugin in case an unsupported type is passed.
…llections#11107) merge_variables: extend type detection failure message Update the error message for the merge_variables lookup plugin in case an unsupported type is passed.
…erge_variables type detection (#11166) Extend failure message for merge_variables type detection (#11107) merge_variables: extend type detection failure message Update the error message for the merge_variables lookup plugin in case an unsupported type is passed. (cherry picked from commit e20e32b) Co-authored-by: Roy Lenferink <[email protected]>
6 participants
Update the error message for the merge_variables lookup plugin in case an unsupported type is passed.
SUMMARY
Improve the failure message in case an not-allowed type is specified.
This allows our users to find errors in plugins early on (e.g. where an input variable with an undefined jinja2 filter is passed).
ISSUE TYPE
Not sure whether it is docs or bugfix, since it is mainly inline documentation.
COMPONENT NAME
merge_variables
ADDITIONAL INFORMATION
N.A.