Skip to content

Support regexp for datastore autoselect #2038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support regexp for datastore autoselect #2038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/regexp-for-autoselect-datastore.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
minor_changes:
- "Support for regular expression when using `autoselect_datastore: True`."
4 changes: 2 additions & 2 deletions plugins/modules/vmware_guest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@
type: str
description:
- The name of datastore which will be used for the disk.
- If O(disk.autoselect_datastore) is set to True, will select the less used datastore whose name contains this "disk.datastore" string.
- If O(disk.autoselect_datastore) is set to True, will select the less used datastore whose name matches this "disk.datastore" pattern.
filename:
type: str
description:
Expand Down Expand Up @@ -2768,7 +2768,7 @@ def select_datastore(self, vm_obj=None):

if (ds.summary.freeSpace > datastore_freespace) or (ds.summary.freeSpace == datastore_freespace and not datastore):
# If datastore field is provided, filter destination datastores
if self.params['disk'][0]['datastore'] and ds.name.find(self.params['disk'][0]['datastore']) < 0:
if self.params['disk'][0]['datastore'] and re.search(self.params['disk'][0]['datastore'], ds.name):
continue

datastore = ds
Expand Down