DRS Override - add state argument #2342

Rogacz · 2025-03-05T11:56:33Z

SUMMARY

Added new state attribute with absent, disabled, enabled options to support missing functionality.
You can now remove existing DRS override or set DRS Override to disabled, which is different from manual.

Also added improvements:

Add name, uuid, moid, options to find VM in same standard as used in other modules, with optional folder, datacenter, use_instance_uuid arguments
Added alias vm_name to name argument to keep backward compatibility
Actually support check_mode as it was ignored previously
Properly handle editing and removal of existing DRS override entry
Expand description

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

vmware_drs_override

ADDITIONAL INFORMATION

At work, I need to create and remove DRS override for VMs, so here is an improved version of the module.

softwarefactory-project-zuul · 2025-03-05T12:01:29Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/150ee2f3859d4fa59078586284c5d5d6

⚠️ ansible-tox-linters CANCELED
❌ build-ansible-collection FAILURE in 4m 39s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable218 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection

softwarefactory-project-zuul · 2025-03-05T12:32:13Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/78c940fd75514529bfbf7fcfa2990b83

❌ ansible-tox-linters FAILURE in 4m 51s
⚠️ build-ansible-collection CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_only-stable218 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 CANCELED
⚠️ ansible-galaxy-importer CANCELED

softwarefactory-project-zuul · 2025-03-05T13:57:50Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/ba428005e6ac4464a6b65320231cfc47

✔️ ansible-tox-linters SUCCESS in 4m 55s
✔️ build-ansible-collection SUCCESS in 7m 45s
✔️ ansible-test-cloud-integration-vcenter7_only-stable218 SUCCESS in 21m 37s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 SUCCESS in 18m 38s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 SUCCESS in 53m 50s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 SUCCESS in 1h 06m 41s
✔️ ansible-galaxy-importer SUCCESS in 4m 17s

softwarefactory-project-zuul · 2025-04-28T11:24:45Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/382a2a5a543b41f98da0cb7b8871f46b

✔️ ansible-tox-linters SUCCESS in 5m 45s
✔️ build-ansible-collection SUCCESS in 7m 32s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable218 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 FAILURE in 15m 32s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 3m 45s (non-voting)

ihumster

I am a little embarrassed by the presence of absent without present - I would add for compatibility and logic present with the same logic as enabled

Rogacz · 2025-04-28T12:15:25Z

I can just rename enabled to present. Options would be present/absent/disabled
My thought process was that both disabled and enabled are present, and didn't want to separate it to state=absent/present and enabled=true/false options.
But I understand it breaks a convention.

softwarefactory-project-zuul · 2025-04-29T09:06:00Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/089645577b5446c7b60f852a33001a7e

✔️ ansible-tox-linters SUCCESS in 5m 40s
✔️ build-ansible-collection SUCCESS in 7m 25s
✔️ ansible-test-cloud-integration-vcenter7_only-stable218 SUCCESS in 17m 32s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 SUCCESS in 14m 38s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 SUCCESS in 1h 11m 13s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 SUCCESS in 48m 35s
✔️ ansible-galaxy-importer SUCCESS in 3m 40s (non-voting)

Rogacz · 2025-04-29T10:46:09Z

I've noticed that tests were skipped

softwarefactory-project-zuul · 2025-04-29T11:11:46Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/d47950839c3343f08956639001a63f9a

✔️ ansible-tox-linters SUCCESS in 5m 39s
✔️ build-ansible-collection SUCCESS in 7m 32s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable218 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 FAILURE in 17m 05s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 3m 32s (non-voting)

Rogacz · 2025-04-29T11:22:57Z

It fails on something unrelated to this PR.
On content library tasks: The provided storage backing rw_datastore for library cfea863b-8db1-4b5f-a54d-8cfe64b9c9ed is inaccessible

Rogacz · 2025-04-30T10:44:39Z

recheck

softwarefactory-project-zuul · 2025-04-30T11:12:37Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/49f2bec902ce4e0ca4a90b425dd144e9

✔️ ansible-tox-linters SUCCESS in 5m 03s
✔️ build-ansible-collection SUCCESS in 8m 37s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable218 CANCELED
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 SUCCESS in 16m 19s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 FAILURE in 13m 02s
✔️ ansible-galaxy-importer SUCCESS in 3m 46s (non-voting)

mariolenz · 2025-05-06T16:28:25Z

I'm sorry, but my priority ATM is to make the collection work with the upcoming ansible-core 2.19 release (#2388 and #2391).

It turns out that this is harder than I originally expected. Please bear wit me 🙏

Rogacz · 2025-07-17T10:18:01Z

recheck

softwarefactory-project-zuul · 2025-07-17T11:30:59Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/19382613f64a4865a330d8f591aa64fe

✔️ ansible-tox-linters SUCCESS in 6m 19s
✔️ ansible-test-cloud-integration-vcenter7_only-stable218 SUCCESS in 24m 17s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 SUCCESS in 22m 00s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 FAILURE in 53m 48s
✔️ ansible-galaxy-importer SUCCESS in 3m 57s (non-voting)
✔️ build-ansible-collection SUCCESS in 6m 29s

Add absent option, Switch to find vm based on standard options, Actually support check_mode

separate state argument with new disabled option, improve description

softwarefactory-project-zuul · 2025-07-17T14:10:04Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/19267de4a3a84bbe94441b9fc667220e

✔️ ansible-tox-linters SUCCESS in 5m 20s
✔️ ansible-test-cloud-integration-vcenter7_only-stable218 SUCCESS in 25m 16s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 SUCCESS in 21m 43s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 SUCCESS in 1h 30m 39s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 SUCCESS in 1h 13m 09s
✔️ ansible-galaxy-importer SUCCESS in 3m 32s (non-voting)
✔️ build-ansible-collection SUCCESS in 6m 19s

softwarefactory-project-zuul · 2025-07-17T15:47:00Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/86cfef2a76844eb488eb18fac0330c26

✔️ ansible-tox-linters SUCCESS in 6m 46s
✔️ ansible-test-cloud-integration-vcenter7_only-stable218 SUCCESS in 26m 49s
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable218 FAILURE in 23m 11s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 4m 34s (non-voting)
✔️ build-ansible-collection SUCCESS in 6m 29s

Rogacz · 2025-09-10T12:54:06Z

recheck

softwarefactory-project-zuul · 2025-09-10T13:05:20Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/05f12dba743d45d49135725a57807699

✔️ ansible-tox-linters SUCCESS in 5m 06s
❌ ansible-galaxy-importer FAILURE in 3m 47s (non-voting)
✔️ build-ansible-collection SUCCESS in 6m 38s

Rogacz force-pushed the drs_override_enchance branch from ef27490 to 31e30eb Compare April 28, 2025 10:59

ihumster reviewed Apr 28, 2025

View reviewed changes

ihumster approved these changes Apr 29, 2025

View reviewed changes

Rogacz added 7 commits July 17, 2025 13:56

enhance drs_override

8a38f25

Add absent option, Switch to find vm based on standard options, Actually support check_mode

add state argument

0d6f5e5

separate state argument with new disabled option, improve description

fix indentation

810e474

fix flake8 lint indent issues

94708f2

add changelog

f222060

change enabled to present

9a294fa

fix tests

bfbb8a2

Rogacz force-pushed the drs_override_enchance branch from e9ebce9 to bfbb8a2 Compare July 17, 2025 15:11

DRS Override - add state argument #2342

Are you sure you want to change the base?

DRS Override - add state argument #2342

Uh oh!

Conversation

Rogacz commented Mar 5, 2025

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

Uh oh!

softwarefactory-project-zuul bot commented Mar 5, 2025

Uh oh!

softwarefactory-project-zuul bot commented Mar 5, 2025

Uh oh!

softwarefactory-project-zuul bot commented Mar 5, 2025

Uh oh!

softwarefactory-project-zuul bot commented Apr 28, 2025

Uh oh!

ihumster left a comment

Choose a reason for hiding this comment

Uh oh!

Rogacz commented Apr 28, 2025

Uh oh!

softwarefactory-project-zuul bot commented Apr 29, 2025

Uh oh!

Rogacz commented Apr 29, 2025

Uh oh!

softwarefactory-project-zuul bot commented Apr 29, 2025

Uh oh!

Rogacz commented Apr 29, 2025

Uh oh!

Rogacz commented Apr 30, 2025

Uh oh!

softwarefactory-project-zuul bot commented Apr 30, 2025

Uh oh!

mariolenz commented May 6, 2025

Uh oh!

Rogacz commented Jul 17, 2025

Uh oh!

softwarefactory-project-zuul bot commented Jul 17, 2025

Uh oh!

softwarefactory-project-zuul bot commented Jul 17, 2025

Uh oh!

softwarefactory-project-zuul bot commented Jul 17, 2025

Uh oh!

Rogacz commented Sep 10, 2025

Uh oh!

softwarefactory-project-zuul bot commented Sep 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants