Skip to content

Conversation

@ArunSaravananBalachandran
Copy link
Collaborator

@ArunSaravananBalachandran ArunSaravananBalachandran commented Jan 6, 2025

SUMMARY
  • Add Enterprise SONiC 'ip_neighbor_interfaces' resource module:
    • Provide data definitions in 'argspec'.
    • Implement 'facts' to gather facts for the module.
    • Implement 'config' to apply configurations for merged, deleted, replaced and overridden states.
    • Implement support for 'check' and 'diff' modes.
  • Define regression and unit test cases to verify correct functionality of ip_neighbor_interfaces resource module.

Model PR: ansible-network/resource_module_models#292

GitHub Issues

List the GitHub issues impacted by this PR. If no Github issues are affected, please indicate this with "N/A".

GitHub Issue #
N/A
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

sonic_ip_neighbor_interfaces

OUTPUT
ADDITIONAL INFORMATION
Checklist:
  • I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
  • I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document
How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Regression report: ip_neighbor_interfaces_regression-2025-09-18-11-56-49.zip

ansible-lint tests/regression/roles/sonic_ip_neighbor_interfaces/

Passed: 0 failure(s), 0 warning(s) on 7 files. Profile 'production' was required, and it passed.

@ArunSaravananBalachandran ArunSaravananBalachandran added the new_resource_module This pull request adds a new resource module label Jan 6, 2025
@stalabi1 stalabi1 added this to the v3.1.0 milestone Jul 18, 2025
Copy link
Collaborator

@stalabi1 stalabi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kerry has merged fixes for the 2 sanity errors so you can synch your branch.

Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed code changes look great. The structure is clean and efficient. The posted test results are all good.

I am posting a couple of comments. They are just questions, but at least one of them may require a minor change (in "merge" handling).

Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the incremental changes to address the issue regarding presence of the 'mac' option when creating a new IP neighbor.

All current proposed code changes and corresponding test results look good.

Approved.

@kerry-meyer kerry-meyer merged commit ba6f0a8 into ansible-collections:main Sep 19, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new_resource_module This pull request adds a new resource module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants