-
Notifications
You must be signed in to change notification settings - Fork 85
Add Dell Enterprise SONiC 'ip_neighbor_interfaces' module #499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dell Enterprise SONiC 'ip_neighbor_interfaces' module #499
Conversation
plugins/module_utils/network/sonic/argspec/ip_neighbor_interfaces/ip_neighbor_interfaces.py
Outdated
Show resolved
Hide resolved
plugins/module_utils/network/sonic/config/ip_neighbor_interfaces/ip_neighbor_interfaces.py
Outdated
Show resolved
Hide resolved
tests/regression/roles/sonic_ip_neighbor_interfaces/tasks/cleanup_tests.yaml
Outdated
Show resolved
Hide resolved
tests/regression/roles/sonic_ip_neighbor_interfaces/tasks/preparation_tests.yaml
Outdated
Show resolved
Hide resolved
stalabi1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kerry has merged fixes for the 2 sanity errors so you can synch your branch.
plugins/module_utils/network/sonic/config/ip_neighbor_interfaces/ip_neighbor_interfaces.py
Show resolved
Hide resolved
plugins/module_utils/network/sonic/config/ip_neighbor_interfaces/ip_neighbor_interfaces.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposed code changes look great. The structure is clean and efficient. The posted test results are all good.
I am posting a couple of comments. They are just questions, but at least one of them may require a minor change (in "merge" handling).
kerry-meyer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the incremental changes to address the issue regarding presence of the 'mac' option when creating a new IP neighbor.
All current proposed code changes and corresponding test results look good.
Approved.
SUMMARY
Model PR: ansible-network/resource_module_models#292
GitHub Issues
List the GitHub issues impacted by this PR. If no Github issues are affected, please indicate this with "N/A".
ISSUE TYPE
COMPONENT NAME
sonic_ip_neighbor_interfaces
OUTPUT
ADDITIONAL INFORMATION
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Regression report: ip_neighbor_interfaces_regression-2025-09-18-11-56-49.zip