-
Notifications
You must be signed in to change notification settings - Fork 85
Update AAA module with Accounting changes #559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AAA module with Accounting changes #559
Conversation
|
There are sanity errors flagged on this PR for the most recent ansible-core and Python versions. I think all of these errors have been fixed by changes made in our base code after this PR was submitted. To pick up the fixes and, hopefully, eliminate the sanity warnings for this PR, please resync the main branch of your fork on this repo, then resync your PR branch to your main branch. There is also a unit test ("Code coverage") failure that I'm hoping will be fixed by doing the resync. If not, this will need investigation and fixing before completing this merge. |
|
Thank you for doing the re-sync of your fork and branch. That eliminated the previously flagged sanity errors. I'm sure you noticed that many new sanity errors appeared on files untouched by your PR when you pushed your changes. These are a result of new checks put in place by Ansible yesterday and we will take care of them. (No further action is requested from you to address these errors.) Also, the code coverage problem that was present earlier was due to a mistake made by Redhat in the Ansible software. They fixed it last night and, after re-running the checks today, the "code coverage" failure is no longer present. I will proceed with doing a final check on this PR and, if it all looks fine, will approve and merge this PR as it currently stands. |
kerry-meyer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All current proposed code changes, test additions, and test results look good.
Thank you for your work to implement the updates for accounting changes in the AAA module for the enterprise_sonic Ansible resource module collection.
Approved.
SUMMARY
Added Accounting support to the AAA module.
ISSUE TYPE
COMPONENT NAME
sonic_aaa
OUTPUT
regression-2025-11-14-19-57-53.pdf
Checklist:**