Skip to content

Conversation

@Divya-N3
Copy link
Contributor

@Divya-N3 Divya-N3 commented May 14, 2025

SUMMARY
Added Accounting support to the AAA module.

ISSUE TYPE

  • Feature Pull Request

COMPONENT NAME
sonic_aaa

OUTPUT
regression-2025-11-14-19-57-53.pdf

Checklist:**

  • I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
  • I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document

@stalabi1 stalabi1 added the enhancement New feature or request label Jul 18, 2025
@stalabi1 stalabi1 added this to the v3.2.0 milestone Jul 18, 2025
@stalabi1 stalabi1 modified the milestones: v3.2.0, v4.0.0 Jul 29, 2025
@kerry-meyer
Copy link
Collaborator

kerry-meyer commented Nov 11, 2025

There are sanity errors flagged on this PR for the most recent ansible-core and Python versions. I think all of these errors have been fixed by changes made in our base code after this PR was submitted. To pick up the fixes and, hopefully, eliminate the sanity warnings for this PR, please resync the main branch of your fork on this repo, then resync your PR branch to your main branch.

There is also a unit test ("Code coverage") failure that I'm hoping will be fixed by doing the resync. If not, this will need investigation and fixing before completing this merge.

@kerry-meyer
Copy link
Collaborator

Thank you for doing the re-sync of your fork and branch.

That eliminated the previously flagged sanity errors.

I'm sure you noticed that many new sanity errors appeared on files untouched by your PR when you pushed your changes. These are a result of new checks put in place by Ansible yesterday and we will take care of them. (No further action is requested from you to address these errors.) Also, the code coverage problem that was present earlier was due to a mistake made by Redhat in the Ansible software. They fixed it last night and, after re-running the checks today, the "code coverage" failure is no longer present.

I will proceed with doing a final check on this PR and, if it all looks fine, will approve and merge this PR as it currently stands.

Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All current proposed code changes, test additions, and test results look good.

Thank you for your work to implement the updates for accounting changes in the AAA module for the enterprise_sonic Ansible resource module collection.

Approved.

@kerry-meyer kerry-meyer merged commit c343e88 into ansible-collections:main Nov 13, 2025
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants