Skip to content

Remove EOF Check #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

Remove EOF Check #786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/changelog-fragments/786.bugfix.rst
View file
Open in desktop
Copy link
Member

@webknjaz webknjaz Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's where you can see the surrounding writing style to adjust your release note: https://ansible-pylibssh--786.org.readthedocs.build/en/786/changelog/#changelog.

Copy link
Member

@webknjaz webknjaz Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, symlink this note to 785.bugfix.rst

Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Remove the SCP EOF message check in the ``get`` method to allow libssh clients
Copy link
Member

@webknjaz webknjaz Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using a TODO-list style imperative mood, use the writing style that explains the effect for the end-users compared to the previous release as if this is already included in a release. Sometimes, using the past tense helps.

get files from Cisco SCP servers. -- by :user:`timway`.
Copy link
Member

@webknjaz webknjaz Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid periods right before the em dash.

Suggested change
get files from Cisco SCP servers. -- by :user:`timway`.
get files from Cisco SCP servers -- by :user:`timway`.

6 changes: 0 additions & 6 deletions src/pylibsshext/scp.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,12 +159,6 @@ cdef class SCP:
remaining_bytes_to_read -= read_bytes
if mode >= 0:
os.chmod(local_file, mode)

# Make sure we have finished requesting files
rc = libssh.ssh_scp_pull_request(scp)
if rc != libssh.SSH_SCP_REQUEST_EOF:
raise LibsshSCPException("Unexpected request: %s" % self._get_ssh_error_str())

finally:
if read_buffer is not NULL:
PyMem_Free(read_buffer)
Expand Down
Loading