Skip to content

fix: properly add assistant_content to messages #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: properly add assistant_content to messages #1049

wants to merge 1 commit into from
+5 −5

Conversation

@HQidea
Copy link

@HQidea HQidea commented Oct 22, 2025

This pr fixes:

  • Variable scope: The assistant_content variable was declared outside the message processing loop, causing content accumulation across multiple messages
  • Message ordering: Assistant messages were being stored after tool results, which violates the correct conversation flow where assistant messages should come before tool results

@HQidea HQidea requested a review from a team as a code owner October 22, 2025 08:12
@HQidea HQidea mentioned this pull request Oct 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@karpetrosyan karpetrosyan karpetrosyan approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HQidea @karpetrosyan