changes for fast navigation #836
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pressing Ctrl + down or up will now select the 10th next music, for fast interaction between huge playlists and your time 😅.
Intended for large playlists, pressing Ctrl+Up/Down will move 10 lines, and also loops correctly on last and first line
aome510
reviewed
Sep 21, 2025
spotify_player/src/config/keymap.rs
Outdated
Comment on lines
240
to
241
| key_sequence: "C-down".into(), | ||
| command: Command::SelectNextOrScrollDown10, |
Owner
There was a problem hiding this comment.
why don't you just bind this key sequence to PageSelectNextOrScrollDown will do scroll down of page_size_in_rows (default to be 20) instead of adding a new command?
Author
There was a problem hiding this comment.
I've made it 10 (or half the page - yet magic number yeah) for better visibility on doing so, but I'll check it
removed the two commands added, now using `PageSelectPreviousOrScrollUp` and `PageSelectNextOrScrollDown` for fast navigation, looping only on single line movement in case it's used on something else
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.