Skip to content

Conversation

@aeroyorch
Copy link
Contributor

closes: #57615

@boring-cyborg
Copy link

boring-cyborg bot commented Nov 9, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@aeroyorch aeroyorch force-pushed the feature-multiple-image-pull-secrets branch 3 times, most recently from f9165b4 to d98ed0b Compare November 9, 2025 14:37
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the extension. I think this is OK and allows more options.

As you are deprecating an existing parameter, can you also please add a newsfragment in chart/newsfragments as RST describing the change such that it can be highlighted in release notes? Then people are (better) aware that they need to adjust parameters when upgrading.

@jscheffl jscheffl force-pushed the feature-multiple-image-pull-secrets branch from d98ed0b to e54ef7a Compare November 9, 2025 18:36
@aeroyorch aeroyorch force-pushed the feature-multiple-image-pull-secrets branch from e54ef7a to ca77b2f Compare November 9, 2025 19:00
@aeroyorch
Copy link
Contributor Author

Done! I added it under miscellaneous changes. Let me know if there’s anything else you’d like adjusted. Thanks!

Thanks for the extension. I think this is OK and allows more options.

As you are deprecating an existing parameter, can you also please add a newsfragment in chart/newsfragments as RST describing the change such that it can be highlighted in release notes? Then people are (better) aware that they need to adjust parameters when upgrading.

@jscheffl jscheffl added this to the Airflow Helm Chart 1.19.0 milestone Nov 9, 2025
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, keeping this oopen for another 2 eyes of review to be merged in the next days

@potiuk potiuk merged commit 7f53be7 into apache:main Nov 9, 2025
84 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Nov 9, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@aeroyorch aeroyorch deleted the feature-multiple-image-pull-secrets branch November 9, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support multiple image pull secrets in Helm values

3 participants