VAT Id Number validators for all EU countries #271
Conversation
Check Digit calculation/validation https://issues.apache.org/jira/projects/VALIDATOR/issues/VALIDATOR-494
Error: Failed to execute goal org.apache.maven.plugins:maven-pmd-plugin:3.24.0:check (default-cli) on project commons-validator: PMD 7.4.0 has found 1 violation. For more details see: /home/runner/work/commons-validator/commons-validator/target/pmd.xml -> [Help 1]
This reverts commit 62c5f75.
minor changes in VATidATCheckDigit
Check Digit calculation/validation It is a subclass from Modulus97CheckDigit, which is also used to validate the LEI and German Leitweg, see apache#61 This implemets parts of https://issues.apache.org/jira/projects/VALIDATOR/issues/VALIDATOR-494
Check Digit calculation/validation https://issues.apache.org/jira/projects/VALIDATOR/issues/VALIDATOR-494
- add testcases with branches
which does not provide a comment (implicit constructor)
|
There are some classes with logging, but not all. What determines whether logging is used? |
|
I wouldn't except any logging from this component. |
apache#271 (comment) There are some classes with logging, but not all. ... Is it really needed? VATidCZCheckDigit : LOG was used only when DebugEnabled VATidBGCheckDigit : dto VATidESCheckDigit : dto VATidFRCheckDigit : dto VATidGBCheckDigit : dto VATidLVCheckDigit : dto + to explain why calculation fails
|
I've removed logging. There is one class with logging left :
@garydgregory |
|
Logging can be completely disabled, so should not be essential to the functioning of a class. In this case, the log messages are directly associated with an exception (apart from an unnecessary debug log), so I don't see the point of them; they don't provide any extra information. I think they should be removed as well please. |
- cvc-elt.1.a: Cannot find the declaration of element 'project'. - Downloading external resources is disabled. Merge remote-tracking branch 'apache/master' into master+vatin
|
when merging apache/master to my repo branch I got an error in The solution is https instead http in pom element 'project' I resolve this in my pull request and hope you accept this pull. It is waiting to be accepted for more then one year! regards EUGen |
pom.xml
Outdated
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/maven-v4_0_0.xsd"> | ||
| <project xmlns="https://maven.apache.org/POM/4.0.0" | ||
| xmlns:xsi="https://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="https://maven.apache.org/POM/4.0.0 https://maven.apache.org/maven-v4_0_0.xsd"> |
There was a problem hiding this comment.
Please revert these changes. They are not valid.
Although the values look like URLs, they are not; they are unique identifiers so must be left as is
This reverts commit 3b500c4.
As mentioned earlier in #271 (comment): keeping this up-to-date looks like quite a maintenance burden. This means the work is valuable to share - but only if we're confident that there will be someone looking after this code after it's merged. I assume you're using this and would be ready to take some of that maintainership on yourself, but it'd be good to have one or two other people showing up. |
5 participants
Hi @garydgregory ,
here is EUgen from Europe.
With this PR I provide validation and check digit calculation for VAT Id Numbers VATIN for all countries in the EU. This number is neccessary in the intra comunity trades to apply a zero VAT rate.
You can find a documentation of the different VATINs structures in my VATIN wiki (de)
The validator for all is
VATINValidator- it implements the jira issue 494Pls review and merge.
Regards EUGen