[fix](datatype)Fix unaligned memory access in read_column_from_arrow #58002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Chen768959
force-pushed
the
fix/arrow-memory-alignment
branch
from
bed85c4 to
24937de
Compare
yiguolei
reviewed
Nov 13, 2025
| if (!concrete_array->IsNull(offset_i)) { | ||
| const auto* raw_data = buffer->data() + concrete_array->value_offset(offset_i); | ||
| const auto raw_data_len = concrete_array->value_length(offset_i); | ||
| int32_t start_offset; |
yiguolei
reviewed
Nov 13, 2025
| } | ||
| for (auto value_i = start; value_i < end; ++value_i) { | ||
| auto utc_epoch = static_cast<UInt64>(concrete_array->Value(value_i)); | ||
| int64_t utc_epoch_raw; |
Contributor
Author
There was a problem hiding this comment.
我补充一下，我想办法构造下各类型的内存未对齐的arrow数据场景
Contributor
|
run buildall |
TPC-H: Total hot run time: 33977 ms |
TPC-DS: Total hot run time: 187925 ms |
ClickBench: Total hot run time: 27.38 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
morningman
previously approved these changes
Nov 19, 2025
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
github-actions
bot
removed
the
approved
Chen768959
force-pushed
the
fix/arrow-memory-alignment
branch
2 times, most recently
from
80b554e to
b5ae674
Compare
Contributor
|
run buildall |
morningman
approved these changes
Nov 20, 2025
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
TPC-H: Total hot run time: 34297 ms |
TPC-DS: Total hot run time: 187936 ms |
ClickBench: Total hot run time: 27.92 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
morningman
force-pushed
the
fix/arrow-memory-alignment
branch
from
b5ae674 to
0a24ddd
Compare
Contributor
|
run buildall |
TPC-H: Total hot run time: 34334 ms |
TPC-DS: Total hot run time: 188375 ms |
ClickBench: Total hot run time: 27.89 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
github-actions bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
…58002) Fix memory alignment issues in read_column_from_arrow by using memcpy This PR addresses potential memory alignment problems when reading data from Arrow arrays in the `read_column_from_arrow` method. Instead of directly casting potentially unaligned pointers, we now use `memcpy` to safely copy data into properly aligned memory, preventing misaligned address runtime errors. Followup #55274
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Nov 20, 2025
…pache#58002) Fix memory alignment issues in read_column_from_arrow by using memcpy This PR addresses potential memory alignment problems when reading data from Arrow arrays in the `read_column_from_arrow` method. Instead of directly casting potentially unaligned pointers, we now use `memcpy` to safely copy data into properly aligned memory, preventing misaligned address runtime errors. Followup apache#55274
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Nov 20, 2025
…pache#58002) Fix memory alignment issues in read_column_from_arrow by using memcpy This PR addresses potential memory alignment problems when reading data from Arrow arrays in the `read_column_from_arrow` method. Instead of directly casting potentially unaligned pointers, we now use `memcpy` to safely copy data into properly aligned memory, preventing misaligned address runtime errors. Followup apache#55274
yiguolei
pushed a commit
that referenced
this pull request
Nov 21, 2025
…_from_arrow #58002 (#58202) Cherry-picked from #58002 Co-authored-by: Chen768959 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix memory alignment issues in read_column_from_arrow by using memcpy
This PR addresses potential memory alignment problems when reading data from Arrow arrays in the
read_column_from_arrowmethod. Instead of directly casting potentially unaligned pointers, we now usememcpyto safely copy data into properly aligned memory, preventing misaligned address runtime errors.Followup #55274