Skip to content

[feat](schema change) enforce key keyword when add key column on AGG table #58138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

[feat](schema change) enforce key keyword when add key column on AGG table #58138

wants to merge 8 commits into from
+45 −36

Conversation

@TsukiokaKogane
Copy link
Contributor

@TsukiokaKogane TsukiokaKogane commented Nov 18, 2025 •
edited
Loading

What problem does this PR solve?

force add key keyword when adding key columns on AGG table, reason:

  1. be consistent with official doc
  2. prevent someone from adding key columns by accident but without proper ways to remove them

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Nov 18, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@TsukiokaKogane
Copy link
Contributor Author

TsukiokaKogane commented Nov 18, 2025

run buildall

@TsukiokaKogane
fix nereids & ut
017f267 
Signed-off-by: TsukiokaKogane <[email protected]>
@TsukiokaKogane
Copy link
Contributor Author

TsukiokaKogane commented Nov 19, 2025

run buildall

@TsukiokaKogane
remove useless import
54e9c0d 
Signed-off-by: TsukiokaKogane <[email protected]>
@doris-robot
Copy link

doris-robot commented Nov 19, 2025

TPC-H: Total hot run time: 34615 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 017f267c41d4f9940f768eb321dfc77c010d605b, data reload: false

------ Round 1 ----------------------------------
q1	17614	5024	4891	4891
q2	2080	318	206	206
q3	10178	1316	740	740
q4	10247	972	378	378
q5	7483	2376	2360	2360
q6	187	167	138	138
q7	913	776	637	637
q8	9356	1335	1116	1116
q9	6893	5091	5105	5091
q10	6812	2230	1823	1823
q11	462	296	285	285
q12	345	371	235	235
q13	17804	3663	3063	3063
q14	233	238	217	217
q15	552	514	496	496
q16	1034	1003	942	942
q17	580	883	363	363
q18	7413	7361	7971	7361
q19	1424	979	569	569
q20	360	355	231	231
q21	4327	3634	2439	2439
q22	1272	1109	1034	1034
Total cold run time: 107569 ms
Total hot run time: 34615 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5166	5160	5259	5160
q2	241	321	230	230
q3	2377	2824	2703	2703
q4	1444	1826	1485	1485
q5	4596	4452	4526	4452
q6	216	167	125	125
q7	2005	1922	1788	1788
q8	2638	2517	2583	2517
q9	7364	7106	7208	7106
q10	3103	3275	2825	2825
q11	583	538	510	510
q12	703	772	646	646
q13	3580	3822	3011	3011
q14	285	275	260	260
q15	528	480	480	480
q16	1011	1055	1010	1010
q17	1085	1490	1314	1314
q18	7315	7287	7183	7183
q19	759	739	831	739
q20	1909	1933	1832	1832
q21	4855	4451	4377	4377
q22	1133	1039	1025	1025
Total cold run time: 52896 ms
Total hot run time: 50778 ms

@doris-robot
Copy link

doris-robot commented Nov 19, 2025

TPC-DS: Total hot run time: 188738 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 017f267c41d4f9940f768eb321dfc77c010d605b, data reload: false

query1	1025	414	410	410
query2	6570	1687	1674	1674
query3	6749	237	223	223
query4	26230	23108	23245	23108
query5	4724	655	497	497
query6	331	242	220	220
query7	4661	498	313	313
query8	295	267	250	250
query9	8671	2943	2937	2937
query10	517	349	316	316
query11	16115	15076	14892	14892
query12	197	136	123	123
query13	1694	578	456	456
query14	11286	9330	9243	9243
query15	202	190	166	166
query16	7699	670	502	502
query17	1232	809	638	638
query18	2087	420	325	325
query19	207	192	178	178
query20	132	125	129	125
query21	216	133	115	115
query22	4024	4264	4039	4039
query23	34208	32991	33098	32991
query24	8123	2366	2357	2357
query25	605	511	459	459
query26	1236	272	172	172
query27	2736	495	367	367
query28	4404	2253	2240	2240
query29	786	625	495	495
query30	305	223	197	197
query31	927	801	684	684
query32	90	89	78	78
query33	595	402	345	345
query34	799	866	564	564
query35	818	820	740	740
query36	969	1019	908	908
query37	125	119	95	95
query38	3584	3510	3473	3473
query39	1481	1412	1428	1412
query40	232	139	125	125
query41	64	60	60	60
query42	129	122	118	118
query43	495	484	468	468
query44	1253	814	809	809
query45	192	179	173	173
query46	881	981	647	647
query47	1744	1796	1750	1750
query48	417	419	326	326
query49	759	502	409	409
query50	660	678	414	414
query51	3843	4039	3828	3828
query52	121	115	112	112
query53	241	279	212	212
query54	341	318	303	303
query55	95	94	91	91
query56	346	349	338	338
query57	1187	1192	1122	1122
query58	297	294	290	290
query59	2504	2606	2594	2594
query60	367	370	343	343
query61	168	161	159	159
query62	792	727	654	654
query63	255	201	196	196
query64	4464	1178	890	890
query65	4032	3946	3940	3940
query66	1116	460	340	340
query67	15430	15156	14915	14915
query68	4875	968	647	647
query69	487	330	298	298
query70	1319	1292	1202	1202
query71	449	359	332	332
query72	6018	5062	5223	5062
query73	654	621	363	363
query74	9316	8881	9059	8881
query75	3274	3232	2803	2803
query76	3343	1143	746	746
query77	514	414	349	349
query78	9536	9674	8922	8922
query79	1581	842	616	616
query80	1145	643	552	552
query81	522	267	233	233
query82	427	170	139	139
query83	274	278	251	251
query84	262	122	100	100
query85	952	506	458	458
query86	334	305	320	305
query87	3687	3730	3585	3585
query88	2841	2230	2231	2230
query89	394	330	290	290
query90	1747	240	218	218
query91	167	177	144	144
query92	86	77	75	75
query93	1193	1024	682	682
query94	748	436	324	324
query95	429	339	340	339
query96	480	588	281	281
query97	2895	2971	2849	2849
query98	249	220	224	220
query99	1300	1394	1289	1289
Total cold run time: 270578 ms
Total hot run time: 188738 ms

@doris-robot
Copy link

doris-robot commented Nov 19, 2025

ClickBench: Total hot run time: 27.68 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 017f267c41d4f9940f768eb321dfc77c010d605b, data reload: false

query1	0.05	0.05	0.05
query2	0.10	0.05	0.05
query3	0.26	0.08	0.08
query4	1.61	0.12	0.11
query5	0.26	0.24	0.25
query6	1.16	0.65	0.65
query7	0.03	0.02	0.03
query8	0.06	0.04	0.05
query9	0.59	0.52	0.52
query10	0.57	0.57	0.58
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.62	0.61	0.61
query14	1.00	0.99	0.99
query15	0.85	0.83	0.84
query16	0.38	0.39	0.39
query17	1.05	1.04	0.98
query18	0.22	0.20	0.20
query19	1.96	1.82	1.78
query20	0.02	0.02	0.01
query21	15.44	0.17	0.13
query22	5.21	0.06	0.05
query23	15.76	0.26	0.11
query24	2.93	0.70	0.86
query25	0.09	0.06	0.05
query26	0.14	0.14	0.13
query27	0.07	0.05	0.05
query28	4.34	1.17	0.94
query29	12.55	3.83	3.21
query30	0.29	0.14	0.12
query31	2.82	0.59	0.39
query32	3.24	0.55	0.48
query33	3.05	3.17	3.08
query34	15.86	5.21	4.50
query35	4.63	4.60	4.57
query36	0.69	0.50	0.48
query37	0.09	0.06	0.07
query38	0.06	0.04	0.03
query39	0.04	0.03	0.03
query40	0.17	0.14	0.13
query41	0.09	0.04	0.03
query42	0.04	0.03	0.03
query43	0.05	0.04	0.03
Total cold run time: 98.75 s
Total hot run time: 27.68 s

@TsukiokaKogane
fix regression
72d8bc6 
Signed-off-by: TsukiokaKogane <[email protected]>
@TsukiokaKogane
Copy link
Contributor Author

TsukiokaKogane commented Nov 19, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Nov 19, 2025

TPC-H: Total hot run time: 35190 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 72d8bc6af0c5a3c36b769358bc163e213ce4cfd0, data reload: false

------ Round 1 ----------------------------------
q1	17660	5084	5007	5007
q2	2034	327	209	209
q3	10200	1281	754	754
q4	10230	944	374	374
q5	7548	2483	2275	2275
q6	199	166	138	138
q7	928	784	639	639
q8	9373	1331	1188	1188
q9	7151	5444	5392	5392
q10	6843	2232	1814	1814
q11	476	298	284	284
q12	342	371	229	229
q13	17781	3657	3014	3014
q14	249	232	214	214
q15	572	516	506	506
q16	1038	1009	937	937
q17	592	891	381	381
q18	7488	7511	7951	7511
q19	1353	1015	582	582
q20	405	348	238	238
q21	4574	3517	2474	2474
q22	1109	1098	1030	1030
Total cold run time: 108145 ms
Total hot run time: 35190 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5223	5156	5098	5098
q2	333	412	304	304
q3	2461	2943	2472	2472
q4	1460	1913	1433	1433
q5	4610	4407	4474	4407
q6	221	162	133	133
q7	2016	1923	1799	1799
q8	2599	2675	2518	2518
q9	7593	7574	7538	7538
q10	3117	3318	2826	2826
q11	564	499	503	499
q12	636	732	584	584
q13	3295	3708	3105	3105
q14	268	276	262	262
q15	543	485	486	485
q16	1008	1041	991	991
q17	1110	1525	1315	1315
q18	7350	7059	7038	7038
q19	818	833	924	833
q20	1917	1958	1865	1865
q21	4899	4393	4200	4200
q22	1094	1034	990	990
Total cold run time: 53135 ms
Total hot run time: 50695 ms

@doris-robot
Copy link

doris-robot commented Nov 19, 2025

TPC-DS: Total hot run time: 188685 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 72d8bc6af0c5a3c36b769358bc163e213ce4cfd0, data reload: false

query1	1011	417	426	417
query2	6565	1694	1723	1694
query3	6754	226	221	221
query4	26295	23013	22793	22793
query5	4430	655	531	531
query6	335	251	231	231
query7	4644	502	300	300
query8	300	267	254	254
query9	8689	2926	2903	2903
query10	514	352	319	319
query11	15900	15040	15197	15040
query12	196	130	127	127
query13	1699	567	473	473
query14	11605	9396	9302	9302
query15	206	188	180	180
query16	7684	683	528	528
query17	1400	845	646	646
query18	2053	440	347	347
query19	215	214	189	189
query20	144	131	135	131
query21	224	134	116	116
query22	3964	4048	3932	3932
query23	33727	33087	32939	32939
query24	8054	2470	2434	2434
query25	647	579	510	510
query26	1250	283	179	179
query27	2731	526	366	366
query28	4442	2263	2252	2252
query29	843	660	564	564
query30	304	230	201	201
query31	960	803	772	772
query32	94	90	86	86
query33	608	425	371	371
query34	853	855	536	536
query35	827	831	767	767
query36	953	985	897	897
query37	128	116	96	96
query38	3626	3587	3447	3447
query39	1479	1418	1400	1400
query40	239	143	130	130
query41	65	60	59	59
query42	137	124	120	120
query43	496	487	470	470
query44	1276	799	816	799
query45	189	187	175	175
query46	895	1000	660	660
query47	1741	1830	1706	1706
query48	396	427	328	328
query49	760	506	415	415
query50	643	681	405	405
query51	3906	3879	3982	3879
query52	123	128	112	112
query53	256	283	210	210
query54	349	335	307	307
query55	99	99	94	94
query56	350	340	336	336
query57	1157	1164	1120	1120
query58	310	320	289	289
query59	2569	2753	2509	2509
query60	376	371	361	361
query61	166	173	162	162
query62	781	703	655	655
query63	233	206	204	204
query64	4508	1193	904	904
query65	4056	3923	3947	3923
query66	1109	440	350	350
query67	15348	14974	14742	14742
query68	8386	962	635	635
query69	474	351	300	300
query70	1359	1301	1231	1231
query71	515	364	333	333
query72	5833	4944	5016	4944
query73	697	604	367	367
query74	9155	9157	8931	8931
query75	4010	3212	2813	2813
query76	3716	1140	746	746
query77	814	421	343	343
query78	9463	9686	8838	8838
query79	2292	875	611	611
query80	689	606	532	532
query81	531	262	237	237
query82	462	174	139	139
query83	265	267	253	253
query84	256	120	99	99
query85	912	518	467	467
query86	401	319	287	287
query87	3694	3744	3629	3629
query88	3754	2250	2269	2250
query89	407	329	296	296
query90	2001	247	241	241
query91	169	166	139	139
query92	96	83	76	76
query93	1859	986	683	683
query94	703	443	331	331
query95	430	358	333	333
query96	481	577	284	284
query97	2920	2949	2874	2874
query98	258	229	213	213
query99	1660	1423	1315	1315
Total cold run time: 277548 ms
Total hot run time: 188685 ms

@doris-robot
Copy link

doris-robot commented Nov 19, 2025

ClickBench: Total hot run time: 27.39 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 72d8bc6af0c5a3c36b769358bc163e213ce4cfd0, data reload: false

query1	0.05	0.05	0.05
query2	0.09	0.05	0.04
query3	0.26	0.08	0.08
query4	1.61	0.11	0.11
query5	0.26	0.25	0.27
query6	1.16	0.64	0.63
query7	0.03	0.03	0.02
query8	0.05	0.04	0.04
query9	0.58	0.54	0.51
query10	0.59	0.57	0.57
query11	0.16	0.12	0.11
query12	0.15	0.11	0.11
query13	0.62	0.60	0.61
query14	1.01	1.00	0.98
query15	0.85	0.82	0.84
query16	0.40	0.39	0.39
query17	1.03	0.99	1.02
query18	0.21	0.20	0.20
query19	1.90	1.82	1.77
query20	0.02	0.01	0.02
query21	15.45	0.22	0.12
query22	5.01	0.07	0.04
query23	15.71	0.26	0.09
query24	3.23	0.56	0.96
query25	0.07	0.07	0.06
query26	0.15	0.12	0.12
query27	0.08	0.05	0.05
query28	5.63	1.18	0.96
query29	12.55	3.85	3.20
query30	0.28	0.14	0.13
query31	2.82	0.58	0.39
query32	3.22	0.55	0.48
query33	2.99	3.02	3.20
query34	15.65	5.19	4.53
query35	4.54	4.60	4.54
query36	0.67	0.49	0.48
query37	0.09	0.06	0.06
query38	0.06	0.04	0.04
query39	0.03	0.02	0.03
query40	0.16	0.14	0.13
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.03	0.03
Total cold run time: 99.59 s
Total hot run time: 27.39 s

@TsukiokaKogane
fix regression v2
abdd799 
Signed-off-by: TsukiokaKogane <[email protected]>
@TsukiokaKogane
Copy link
Contributor Author

TsukiokaKogane commented Nov 19, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Nov 19, 2025

TPC-H: Total hot run time: 35405 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit abdd799ee1e55a3e2a2a02cba8330472b75f7511, data reload: false

------ Round 1 ----------------------------------
q1	17637	4998	4864	4864
q2	1991	312	212	212
q3	10277	1279	700	700
q4	10228	879	350	350
q5	7521	2464	2261	2261
q6	185	172	136	136
q7	929	747	626	626
q8	9358	1351	1135	1135
q9	7018	5422	5462	5422
q10	6904	2183	1821	1821
q11	509	300	289	289
q12	343	377	232	232
q13	17833	3664	3031	3031
q14	229	234	211	211
q15	575	530	502	502
q16	1035	982	934	934
q17	582	869	353	353
q18	7335	7423	7530	7423
q19	1498	1021	603	603
q20	386	343	223	223
q21	4175	3299	3031	3031
q22	1124	1085	1046	1046
Total cold run time: 107672 ms
Total hot run time: 35405 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5120	5256	5155	5155
q2	325	392	299	299
q3	2382	2917	2442	2442
q4	1447	1840	1477	1477
q5	4518	4376	4426	4376
q6	207	173	121	121
q7	1937	1947	1777	1777
q8	2616	2597	2544	2544
q9	7450	7348	6939	6939
q10	2881	3120	2666	2666
q11	562	494	479	479
q12	636	710	559	559
q13	3282	3601	3033	3033
q14	290	289	272	272
q15	527	482	483	482
q16	1026	1052	986	986
q17	1090	1414	1323	1323
q18	7177	7152	7018	7018
q19	757	739	905	739
q20	1925	1952	1838	1838
q21	4697	4238	4313	4238
q22	1095	1018	991	991
Total cold run time: 51947 ms
Total hot run time: 49754 ms

@doris-robot
Copy link

doris-robot commented Nov 19, 2025

TPC-DS: Total hot run time: 187753 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit abdd799ee1e55a3e2a2a02cba8330472b75f7511, data reload: false

query1	1028	412	456	412
query2	6550	1664	1662	1662
query3	6751	235	226	226
query4	25921	23194	22517	22517
query5	4329	637	500	500
query6	325	234	229	229
query7	4653	488	298	298
query8	301	255	246	246
query9	8695	2936	2897	2897
query10	488	352	300	300
query11	15745	15202	14738	14738
query12	179	121	114	114
query13	1673	563	456	456
query14	11055	9147	9003	9003
query15	203	187	174	174
query16	7427	662	528	528
query17	1228	745	618	618
query18	2005	431	329	329
query19	209	205	181	181
query20	134	128	118	118
query21	217	135	121	121
query22	4099	4082	4156	4082
query23	33850	33059	33072	33059
query24	8213	2378	2378	2378
query25	619	539	521	521
query26	1240	270	164	164
query27	2763	500	359	359
query28	4395	2239	2210	2210
query29	792	616	509	509
query30	303	218	196	196
query31	927	791	709	709
query32	97	79	81	79
query33	589	386	348	348
query34	789	836	515	515
query35	825	833	749	749
query36	984	1017	900	900
query37	130	111	103	103
query38	3479	3566	3455	3455
query39	1451	1431	1431	1431
query40	245	134	122	122
query41	63	60	60	60
query42	130	115	117	115
query43	475	500	455	455
query44	1239	800	792	792
query45	183	179	172	172
query46	882	997	646	646
query47	1744	1802	1774	1774
query48	408	428	328	328
query49	751	499	463	463
query50	649	681	398	398
query51	3892	3911	3911	3911
query52	119	115	107	107
query53	251	278	200	200
query54	324	309	310	309
query55	90	91	90	90
query56	358	344	356	344
query57	1176	1190	1125	1125
query58	295	281	289	281
query59	2474	2623	2485	2485
query60	353	363	337	337
query61	160	155	161	155
query62	782	702	663	663
query63	230	195	196	195
query64	4486	1168	910	910
query65	4021	3945	3930	3930
query66	1154	453	369	369
query67	15295	15145	14900	14900
query68	3468	982	653	653
query69	496	357	311	311
query70	1312	1251	1301	1251
query71	428	359	327	327
query72	6224	5085	5108	5085
query73	645	583	360	360
query74	8837	9036	8785	8785
query75	3203	3261	2739	2739
query76	3267	1114	735	735
query77	499	403	359	359
query78	9595	9926	8971	8971
query79	2309	800	622	622
query80	1750	603	538	538
query81	559	260	238	238
query82	419	161	142	142
query83	355	261	255	255
query84	249	116	98	98
query85	927	489	450	450
query86	386	301	326	301
query87	3693	3701	3578	3578
query88	2799	2238	2200	2200
query89	416	328	291	291
query90	1747	231	221	221
query91	174	163	134	134
query92	85	75	79	75
query93	1209	1015	687	687
query94	698	426	335	335
query95	429	348	333	333
query96	476	600	286	286
query97	2943	2960	2843	2843
query98	233	215	213	213
query99	1277	1377	1267	1267
Total cold run time: 267997 ms
Total hot run time: 187753 ms

@doris-robot
Copy link

doris-robot commented Nov 19, 2025

ClickBench: Total hot run time: 27.49 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit abdd799ee1e55a3e2a2a02cba8330472b75f7511, data reload: false

query1	0.05	0.05	0.04
query2	0.10	0.06	0.05
query3	0.25	0.08	0.08
query4	1.62	0.11	0.10
query5	0.27	0.25	0.25
query6	1.18	0.63	0.65
query7	0.04	0.03	0.02
query8	0.05	0.04	0.04
query9	0.57	0.53	0.52
query10	0.58	0.57	0.58
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.63	0.60	0.59
query14	1.00	1.00	1.01
query15	0.86	0.83	0.82
query16	0.40	0.38	0.39
query17	1.05	0.99	1.03
query18	0.21	0.19	0.20
query19	1.88	1.78	1.82
query20	0.02	0.01	0.01
query21	15.44	0.21	0.13
query22	5.01	0.07	0.05
query23	15.67	0.27	0.10
query24	2.24	0.52	0.48
query25	0.06	0.08	0.06
query26	0.14	0.14	0.14
query27	0.07	0.06	0.06
query28	4.28	1.14	0.94
query29	12.59	3.84	3.29
query30	0.27	0.13	0.11
query31	2.81	0.59	0.39
query32	3.23	0.56	0.48
query33	3.08	3.07	3.08
query34	15.78	5.16	4.53
query35	4.59	4.60	4.54
query36	0.68	0.51	0.48
query37	0.09	0.07	0.07
query38	0.07	0.04	0.04
query39	0.04	0.02	0.02
query40	0.18	0.14	0.15
query41	0.08	0.04	0.03
query42	0.03	0.03	0.02
query43	0.04	0.04	0.03
Total cold run time: 97.53 s
Total hot run time: 27.49 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 19, 2025

FE UT Coverage Report

Increment line coverage 57.14% (4/7) 🎉
Increment coverage report
Complete coverage report

@TsukiokaKogane
fix regression v3
340116d 
Signed-off-by: TsukiokaKogane <[email protected]>
@TsukiokaKogane
Copy link
Contributor Author

TsukiokaKogane commented Nov 19, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Nov 19, 2025

TPC-H: Total hot run time: 34170 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 340116dd248838a42e9482a6e431aa3e718ebcc0, data reload: false

------ Round 1 ----------------------------------
q1	17622	5035	4949	4949
q2	2013	320	205	205
q3	10243	1280	748	748
q4	10231	894	370	370
q5	7478	2492	2243	2243
q6	187	173	137	137
q7	954	759	626	626
q8	9364	1335	1085	1085
q9	7257	5351	5312	5312
q10	6815	2232	1795	1795
q11	495	299	283	283
q12	337	359	236	236
q13	17777	3642	3049	3049
q14	232	225	224	224
q15	578	509	512	509
q16	1012	1000	941	941
q17	575	858	360	360
q18	7374	7309	7035	7035
q19	1220	948	533	533
q20	351	360	234	234
q21	3818	3193	2302	2302
q22	1076	1042	994	994
Total cold run time: 107009 ms
Total hot run time: 34170 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4971	4918	4910	4910
q2	338	398	322	322
q3	2155	2684	2315	2315
q4	1363	1739	1317	1317
q5	4187	4395	4606	4395
q6	208	172	135	135
q7	2070	2003	1831	1831
q8	2615	2611	2662	2611
q9	7567	7578	7808	7578
q10	3077	3208	2872	2872
q11	596	620	512	512
q12	667	785	589	589
q13	3432	4125	3352	3352
q14	288	299	269	269
q15	536	505	502	502
q16	1079	1138	1084	1084
q17	1156	1755	1364	1364
q18	7837	7632	7612	7612
q19	821	802	929	802
q20	2060	2138	1945	1945
q21	5087	4622	4474	4474
q22	1147	1140	1016	1016
Total cold run time: 53257 ms
Total hot run time: 51807 ms

@doris-robot
Copy link

doris-robot commented Nov 19, 2025

TPC-DS: Total hot run time: 188717 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 340116dd248838a42e9482a6e431aa3e718ebcc0, data reload: false

query1	1021	409	393	393
query2	6564	1704	1650	1650
query3	6747	237	224	224
query4	26411	23310	23504	23310
query5	4859	664	509	509
query6	328	254	234	234
query7	4653	497	315	315
query8	302	257	261	257
query9	8686	2948	2917	2917
query10	519	333	305	305
query11	16067	15045	14873	14873
query12	186	120	120	120
query13	1696	604	456	456
query14	10695	9349	9217	9217
query15	203	197	180	180
query16	7355	660	505	505
query17	1229	803	626	626
query18	2036	440	345	345
query19	217	214	192	192
query20	140	131	127	127
query21	222	137	122	122
query22	3985	4155	3991	3991
query23	34166	33300	32879	32879
query24	8135	2417	2427	2417
query25	642	577	485	485
query26	1247	284	175	175
query27	2730	497	366	366
query28	4377	2266	2256	2256
query29	875	647	538	538
query30	308	225	197	197
query31	900	811	727	727
query32	96	87	87	87
query33	619	423	355	355
query34	794	881	533	533
query35	813	830	761	761
query36	938	988	896	896
query37	136	119	152	119
query38	3560	3483	3441	3441
query39	1469	1409	1428	1409
query40	230	141	131	131
query41	67	60	59	59
query42	129	125	122	122
query43	486	497	458	458
query44	1305	797	795	795
query45	189	201	181	181
query46	903	997	652	652
query47	1740	1756	1709	1709
query48	400	442	342	342
query49	777	515	421	421
query50	674	715	436	436
query51	3902	3895	3939	3895
query52	127	118	117	117
query53	257	284	202	202
query54	346	332	320	320
query55	98	94	92	92
query56	369	358	346	346
query57	1185	1191	1118	1118
query58	299	293	282	282
query59	2531	2555	2486	2486
query60	364	381	368	368
query61	164	159	161	159
query62	771	716	669	669
query63	230	203	203	203
query64	4593	1155	925	925
query65	4031	3920	3928	3920
query66	1183	457	344	344
query67	15383	15173	15044	15044
query68	8374	961	645	645
query69	503	328	304	304
query70	1386	1330	1263	1263
query71	486	357	326	326
query72	5854	4937	4864	4864
query73	691	595	378	378
query74	9204	8933	8632	8632
query75	3912	3231	2795	2795
query76	3735	1150	753	753
query77	830	423	348	348
query78	9372	9792	8799	8799
query79	2183	855	629	629
query80	679	598	529	529
query81	494	276	237	237
query82	428	165	141	141
query83	270	268	257	257
query84	271	113	116	113
query85	916	494	449	449
query86	343	309	308	308
query87	3776	3709	3644	3644
query88	3184	2252	2228	2228
query89	396	349	296	296
query90	1978	242	236	236
query91	167	171	140	140
query92	91	82	73	73
query93	1182	1031	695	695
query94	709	433	337	337
query95	414	350	343	343
query96	485	581	285	285
query97	2919	3011	2880	2880
query98	252	224	224	224
query99	1478	1386	1261	1261
Total cold run time: 275621 ms
Total hot run time: 188717 ms

@doris-robot
Copy link

doris-robot commented Nov 19, 2025

ClickBench: Total hot run time: 27.42 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 340116dd248838a42e9482a6e431aa3e718ebcc0, data reload: false

query1	0.06	0.06	0.05
query2	0.09	0.05	0.05
query3	0.25	0.08	0.08
query4	1.60	0.12	0.11
query5	0.27	0.25	0.25
query6	1.19	0.65	0.65
query7	0.03	0.03	0.03
query8	0.05	0.04	0.04
query9	0.58	0.52	0.52
query10	0.58	0.58	0.57
query11	0.16	0.11	0.11
query12	0.16	0.12	0.12
query13	0.62	0.60	0.60
query14	1.00	0.99	0.99
query15	0.84	0.82	0.83
query16	0.39	0.39	0.39
query17	1.03	1.05	1.02
query18	0.21	0.20	0.19
query19	1.88	1.82	1.87
query20	0.02	0.01	0.02
query21	15.44	0.22	0.13
query22	4.93	0.07	0.05
query23	15.66	0.25	0.10
query24	3.02	0.88	0.31
query25	0.06	0.05	0.06
query26	0.13	0.13	0.13
query27	0.06	0.06	0.05
query28	3.63	1.13	0.95
query29	12.56	3.85	3.23
query30	0.28	0.14	0.14
query31	2.81	0.56	0.40
query32	3.22	0.55	0.47
query33	3.06	3.12	3.05
query34	15.75	5.17	4.58
query35	4.63	4.54	4.60
query36	0.67	0.50	0.48
query37	0.09	0.07	0.07
query38	0.06	0.04	0.04
query39	0.03	0.02	0.02
query40	0.17	0.14	0.13
query41	0.08	0.02	0.02
query42	0.04	0.03	0.03
query43	0.04	0.03	0.04
Total cold run time: 97.43 s
Total hot run time: 27.42 s

@TsukiokaKogane
fix regression v4
efb592d 
Signed-off-by: TsukiokaKogane <[email protected]>
@TsukiokaKogane
Copy link
Contributor Author

TsukiokaKogane commented Nov 19, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Nov 19, 2025

TPC-H: Total hot run time: 33857 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit efb592d9629402538a7e99d97d891327c924805d, data reload: false

------ Round 1 ----------------------------------
q1	17610	5039	4896	4896
q2	2022	307	200	200
q3	10289	1244	705	705
q4	10238	889	364	364
q5	7584	2483	2255	2255
q6	184	171	134	134
q7	988	752	606	606
q8	9341	1320	1108	1108
q9	7026	5288	5267	5267
q10	6843	2193	1805	1805
q11	498	281	283	281
q12	328	369	228	228
q13	17789	3670	2977	2977
q14	235	232	215	215
q15	578	512	496	496
q16	988	1000	933	933
q17	577	859	365	365
q18	7456	7183	7038	7038
q19	1196	930	535	535
q20	347	354	225	225
q21	3669	3113	2251	2251
q22	1059	1051	973	973
Total cold run time: 106845 ms
Total hot run time: 33857 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4924	5198	4912	4912
q2	326	395	310	310
q3	2182	2645	2329	2329
q4	1295	1750	1331	1331
q5	4153	4346	4462	4346
q6	219	175	138	138
q7	2081	1987	1804	1804
q8	2703	2620	2517	2517
q9	7611	7572	7608	7572
q10	3015	3228	2843	2843
q11	585	533	511	511
q12	705	780	768	768
q13	3424	3864	3228	3228
q14	287	300	295	295
q15	540	491	529	491
q16	1070	1117	1054	1054
q17	1361	1556	1384	1384
q18	7899	7729	7640	7640
q19	751	762	798	762
q20	1993	2038	1940	1940
q21	4914	4228	4263	4228
q22	1079	1049	1020	1020
Total cold run time: 53117 ms
Total hot run time: 51423 ms

@doris-robot
Copy link

doris-robot commented Nov 19, 2025

TPC-DS: Total hot run time: 187772 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit efb592d9629402538a7e99d97d891327c924805d, data reload: false

query1	1018	436	394	394
query2	6578	1673	1681	1673
query3	6752	232	221	221
query4	25824	23531	22826	22826
query5	4370	652	519	519
query6	332	255	227	227
query7	4647	503	306	306
query8	313	249	244	244
query9	8693	2885	2912	2885
query10	503	347	305	305
query11	15588	14981	14765	14765
query12	197	125	123	123
query13	1692	575	459	459
query14	10251	9246	9166	9166
query15	206	190	180	180
query16	7303	683	489	489
query17	1277	787	664	664
query18	2034	440	350	350
query19	218	213	193	193
query20	131	129	124	124
query21	217	141	120	120
query22	3971	3948	3916	3916
query23	34166	32971	33084	32971
query24	8150	2411	2403	2403
query25	640	573	520	520
query26	1246	273	178	178
query27	2739	520	377	377
query28	4421	2256	2237	2237
query29	863	646	536	536
query30	295	229	196	196
query31	906	811	733	733
query32	94	81	90	81
query33	609	408	368	368
query34	788	852	529	529
query35	828	827	776	776
query36	952	1001	915	915
query37	132	121	98	98
query38	3504	3533	3500	3500
query39	1495	1412	1413	1412
query40	227	133	123	123
query41	64	58	62	58
query42	133	116	116	116
query43	481	482	434	434
query44	1266	805	813	805
query45	188	184	173	173
query46	888	985	645	645
query47	1739	1780	1718	1718
query48	395	427	326	326
query49	743	496	422	422
query50	648	682	416	416
query51	3893	3933	3868	3868
query52	120	113	107	107
query53	249	267	198	198
query54	326	327	293	293
query55	97	91	89	89
query56	338	327	340	327
query57	1206	1177	1141	1141
query58	304	288	284	284
query59	2499	2644	2418	2418
query60	365	357	351	351
query61	162	153	159	153
query62	796	694	674	674
query63	233	196	193	193
query64	4562	1217	885	885
query65	4032	3933	3963	3933
query66	1184	432	364	364
query67	15303	14975	14951	14951
query68	8261	968	633	633
query69	497	331	284	284
query70	1375	1295	1289	1289
query71	492	361	326	326
query72	6043	4842	4881	4842
query73	682	578	373	373
query74	9070	8917	8741	8741
query75	3832	3266	2738	2738
query76	3672	1124	754	754
query77	819	411	331	331
query78	9406	9790	8795	8795
query79	1819	845	609	609
query80	668	605	514	514
query81	479	257	222	222
query82	427	170	144	144
query83	273	265	258	258
query84	253	105	93	93
query85	930	494	459	459
query86	344	337	313	313
query87	3762	3660	3606	3606
query88	2902	2288	2259	2259
query89	393	321	309	309
query90	1925	240	233	233
query91	167	168	137	137
query92	93	77	75	75
query93	1103	1004	690	690
query94	727	446	335	335
query95	432	344	345	344
query96	504	665	288	288
query97	2944	2973	2863	2863
query98	247	223	216	216
query99	1395	1378	1255	1255
Total cold run time: 272320 ms
Total hot run time: 187772 ms

@doris-robot
Copy link

doris-robot commented Nov 19, 2025

ClickBench: Total hot run time: 27.66 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit efb592d9629402538a7e99d97d891327c924805d, data reload: false

query1	0.06	0.05	0.05
query2	0.09	0.05	0.05
query3	0.26	0.08	0.08
query4	1.60	0.10	0.10
query5	0.27	0.25	0.25
query6	1.16	0.65	0.63
query7	0.03	0.03	0.02
query8	0.05	0.04	0.05
query9	0.56	0.52	0.52
query10	0.57	0.56	0.56
query11	0.16	0.11	0.11
query12	0.15	0.12	0.11
query13	0.62	0.60	0.62
query14	0.98	1.00	0.99
query15	0.84	0.82	0.82
query16	0.39	0.38	0.39
query17	1.01	1.00	1.01
query18	0.22	0.20	0.20
query19	1.88	1.84	1.78
query20	0.02	0.01	0.02
query21	15.43	0.20	0.12
query22	5.01	0.07	0.05
query23	15.68	0.26	0.10
query24	2.86	0.75	1.37
query25	0.09	0.06	0.05
query26	0.13	0.14	0.12
query27	0.08	0.06	0.05
query28	5.45	1.20	0.96
query29	12.57	3.93	3.23
query30	0.29	0.13	0.14
query31	2.82	0.59	0.39
query32	3.22	0.54	0.48
query33	3.03	3.15	3.03
query34	15.62	5.18	4.56
query35	4.57	4.60	4.50
query36	0.67	0.51	0.49
query37	0.10	0.07	0.06
query38	0.07	0.04	0.04
query39	0.03	0.03	0.03
query40	0.17	0.15	0.13
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 98.98 s
Total hot run time: 27.66 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 19, 2025

FE Regression Coverage Report

Increment line coverage 57.14% (4/7) 🎉
Increment coverage report
Complete coverage report

@TsukiokaKogane
fix regression v5
a20f6d8 
Signed-off-by: TsukiokaKogane <[email protected]>
@TsukiokaKogane
Copy link
Contributor Author

TsukiokaKogane commented Nov 20, 2025

run buildall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TsukiokaKogane @Thearas @doris-robot @hello-stephen