Skip to content

branch-4.0: [opt](ann index) Introduce IDSelectorRoaring for a faster roaring_to_faiss_selector #58095 #58177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2025
Merged

branch-4.0: [opt](ann index) Introduce IDSelectorRoaring for a faster roaring_to_faiss_selector #58095 #58177

merged 1 commit into from
Nov 20, 2025
+69 −9

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 20, 2025

Cherry-picked from #58095

@zhiqiang-hhhh
[opt](ann index) Introduce IDSelectorRoaring for a faster roaring_to_…
b70863d 
…faiss_selector (#58095)

### What problem does this PR solve?

Previous, roaring_to_faiss_selector is slow since we need to iterator
through all elements of roaring to get an IDSelector, so we introduce a
simple IDSelectorRoaring which holds a pointer to the original roaring
bitmap to avoid costing too much in roaring_to_faiss_selector.
@github-actions github-actions bot requested a review from yiguolei as a code owner November 20, 2025 06:15
@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 20, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 20, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Nov 20, 2025

BE UT Coverage Report

Increment line coverage 100.00% (10/10) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.81% (18162/34394)
Line Coverage 38.14% (165336/433523)
Region Coverage 33.15% (128415/387386)
Branch Coverage 33.95% (55384/163112)

@yiguolei yiguolei closed this Nov 20, 2025
@yiguolei yiguolei reopened this Nov 20, 2025
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 20, 2025
@github-actions
Copy link
Contributor Author

github-actions bot commented Nov 20, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor Author

github-actions bot commented Nov 20, 2025

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 0cf45d1 into branch-4.0 Nov 20, 2025
24 of 27 checks passed
@github-actions github-actions bot deleted the auto-pick-58095-branch-4.0 branch November 20, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hello-stephen @doris-robot @yiguolei @zhiqiang-hhhh