Skip to content

Conversation

@xy720
Copy link
Member

@xy720 xy720 commented Nov 20, 2025

What problem does this PR solve?

Use the index's key type instead of base table's keys type.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Nov 20, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@xy720
Copy link
Member Author

xy720 commented Nov 20, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34605 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c9e22c90bc1a877b68096db6713356311ec9a225, data reload: false

------ Round 1 ----------------------------------
q1	17604	5223	4881	4881
q2	1994	313	211	211
q3	10255	1270	696	696
q4	10232	957	369	369
q5	7534	2387	2356	2356
q6	181	181	135	135
q7	936	775	629	629
q8	9353	1322	1024	1024
q9	6994	5386	5326	5326
q10	6878	2315	1833	1833
q11	496	306	289	289
q12	346	358	226	226
q13	17771	3614	3017	3017
q14	223	233	209	209
q15	574	516	496	496
q16	999	991	920	920
q17	569	857	347	347
q18	7731	7336	7805	7336
q19	1247	982	557	557
q20	384	383	235	235
q21	4002	3296	2448	2448
q22	1126	1065	1069	1065
Total cold run time: 107429 ms
Total hot run time: 34605 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5119	5132	5218	5132
q2	333	404	314	314
q3	2316	2870	2509	2509
q4	1427	1840	1429	1429
q5	4585	4442	4406	4406
q6	207	177	122	122
q7	2047	1949	1843	1843
q8	2642	2591	2488	2488
q9	7536	7366	7013	7013
q10	2884	3066	2654	2654
q11	560	506	484	484
q12	596	723	579	579
q13	3193	3613	3082	3082
q14	263	278	257	257
q15	541	520	485	485
q16	1026	1037	1011	1011
q17	1086	1431	1334	1334
q18	7298	7114	7128	7114
q19	743	785	909	785
q20	1937	2011	1803	1803
q21	4632	4320	4288	4288
q22	1060	1045	986	986
Total cold run time: 52031 ms
Total hot run time: 50118 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 187090 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c9e22c90bc1a877b68096db6713356311ec9a225, data reload: false

query1	1061	408	393	393
query2	6567	1662	1640	1640
query3	6754	223	219	219
query4	26154	23185	22685	22685
query5	4320	624	464	464
query6	310	243	232	232
query7	4643	486	295	295
query8	292	246	234	234
query9	8697	2591	2595	2591
query10	508	357	297	297
query11	15755	15374	14807	14807
query12	182	119	114	114
query13	1704	595	456	456
query14	11148	9193	9184	9184
query15	201	193	172	172
query16	7539	676	513	513
query17	1250	779	633	633
query18	2019	423	333	333
query19	213	215	190	190
query20	138	122	123	122
query21	223	134	123	123
query22	4090	3988	4025	3988
query23	34069	33261	32907	32907
query24	8483	2460	2412	2412
query25	611	551	477	477
query26	1238	274	164	164
query27	2773	506	361	361
query28	4378	2182	2187	2182
query29	824	667	532	532
query30	301	225	196	196
query31	936	795	724	724
query32	86	80	78	78
query33	614	397	336	336
query34	775	850	566	566
query35	805	825	730	730
query36	938	997	898	898
query37	122	110	82	82
query38	3457	3521	3437	3437
query39	1479	1407	1413	1407
query40	225	126	117	117
query41	64	61	64	61
query42	134	111	113	111
query43	477	483	449	449
query44	1237	773	774	773
query45	183	178	175	175
query46	877	982	632	632
query47	1769	1749	1720	1720
query48	408	432	328	328
query49	776	485	409	409
query50	641	672	404	404
query51	3932	3998	3930	3930
query52	111	108	107	107
query53	247	267	197	197
query54	298	296	275	275
query55	87	85	82	82
query56	333	323	297	297
query57	1173	1162	1110	1110
query58	319	265	272	265
query59	2456	2597	2488	2488
query60	340	347	328	328
query61	162	162	149	149
query62	772	761	651	651
query63	229	190	197	190
query64	4485	1152	857	857
query65	4055	3938	3918	3918
query66	1143	416	331	331
query67	15445	15007	14984	14984
query68	8240	958	631	631
query69	474	323	289	289
query70	1322	1310	1279	1279
query71	482	332	315	315
query72	5804	4907	4843	4843
query73	683	608	363	363
query74	8812	9196	8772	8772
query75	3976	3315	2842	2842
query76	3748	1151	750	750
query77	839	385	333	333
query78	9500	9697	8915	8915
query79	2053	827	594	594
query80	675	602	510	510
query81	517	261	223	223
query82	447	162	131	131
query83	276	274	254	254
query84	257	113	96	96
query85	919	499	437	437
query86	341	312	290	290
query87	3725	3757	3691	3691
query88	3567	2280	2261	2261
query89	386	331	300	300
query90	2003	243	224	224
query91	165	164	135	135
query92	80	71	64	64
query93	1213	1032	692	692
query94	720	456	355	355
query95	414	317	306	306
query96	494	566	278	278
query97	2943	2961	2912	2912
query98	255	213	204	204
query99	1416	1383	1289	1289
Total cold run time: 274781 ms
Total hot run time: 187090 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.69 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c9e22c90bc1a877b68096db6713356311ec9a225, data reload: false

query1	0.05	0.06	0.05
query2	0.10	0.05	0.05
query3	0.25	0.09	0.08
query4	1.60	0.12	0.11
query5	0.27	0.25	0.26
query6	1.17	0.66	0.65
query7	0.04	0.02	0.03
query8	0.05	0.04	0.05
query9	0.60	0.51	0.50
query10	0.57	0.56	0.56
query11	0.15	0.11	0.12
query12	0.15	0.11	0.12
query13	0.62	0.60	0.61
query14	1.01	1.00	1.00
query15	0.85	0.84	0.83
query16	0.38	0.42	0.41
query17	1.07	1.02	1.00
query18	0.22	0.20	0.20
query19	1.90	1.78	1.82
query20	0.01	0.02	0.01
query21	15.53	0.17	0.13
query22	5.10	0.07	0.05
query23	15.65	0.27	0.10
query24	2.78	1.12	0.68
query25	0.07	0.07	0.07
query26	0.15	0.13	0.14
query27	0.09	0.05	0.05
query28	4.90	1.15	0.95
query29	12.55	3.94	3.21
query30	0.28	0.14	0.12
query31	2.81	0.60	0.38
query32	3.23	0.56	0.47
query33	3.00	3.09	3.03
query34	15.84	5.17	4.56
query35	4.63	4.64	4.55
query36	0.70	0.50	0.48
query37	0.10	0.06	0.06
query38	0.06	0.05	0.04
query39	0.03	0.04	0.04
query40	0.18	0.14	0.14
query41	0.09	0.03	0.03
query42	0.04	0.03	0.02
query43	0.04	0.04	0.04
Total cold run time: 98.91 s
Total hot run time: 27.69 s

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 20, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@xy720
Copy link
Member Author

xy720 commented Nov 21, 2025

run p0

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

@xy720
Copy link
Member Author

xy720 commented Nov 21, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34104 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e92bab51d5eb2436d0d036651189bfc06cab0245, data reload: false

------ Round 1 ----------------------------------
q1	17641	4995	4935	4935
q2	2049	310	198	198
q3	10228	1297	707	707
q4	10234	882	367	367
q5	7537	2347	2343	2343
q6	183	172	137	137
q7	913	755	654	654
q8	9371	1263	1053	1053
q9	7181	5542	5440	5440
q10	6881	2207	1785	1785
q11	484	306	276	276
q12	336	360	219	219
q13	17772	3626	3016	3016
q14	228	232	217	217
q15	580	515	493	493
q16	1019	1008	915	915
q17	580	874	364	364
q18	7387	7121	6999	6999
q19	1082	937	541	541
q20	356	335	222	222
q21	3572	2487	2230	2230
q22	1097	1033	993	993
Total cold run time: 106711 ms
Total hot run time: 34104 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4914	4906	4902	4902
q2	325	394	316	316
q3	2171	2657	2321	2321
q4	1359	1738	1313	1313
q5	4165	4214	4521	4214
q6	212	176	129	129
q7	2036	2002	1872	1872
q8	2796	2616	2809	2616
q9	7599	7499	7711	7499
q10	3090	3208	2834	2834
q11	597	534	530	530
q12	682	757	640	640
q13	3559	3872	3404	3404
q14	281	291	307	291
q15	552	515	513	513
q16	1077	1114	1036	1036
q17	1135	1479	1363	1363
q18	7812	7958	7411	7411
q19	767	839	860	839
q20	2009	1957	1809	1809
q21	4771	4315	4159	4159
q22	1101	1049	1005	1005
Total cold run time: 53010 ms
Total hot run time: 51016 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 187095 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e92bab51d5eb2436d0d036651189bfc06cab0245, data reload: false

query1	1041	394	387	387
query2	6565	1671	1656	1656
query3	6756	231	221	221
query4	26987	23271	23046	23046
query5	4426	629	462	462
query6	350	248	233	233
query7	4647	503	296	296
query8	317	256	247	247
query9	8726	2619	2600	2600
query10	488	369	287	287
query11	15704	15130	14825	14825
query12	183	120	112	112
query13	1693	582	472	472
query14	10765	9150	9065	9065
query15	197	192	167	167
query16	7486	669	521	521
query17	1229	780	609	609
query18	2010	410	321	321
query19	214	198	175	175
query20	125	126	119	119
query21	215	139	122	122
query22	4121	4263	4154	4154
query23	33827	32993	32934	32934
query24	8456	2430	2387	2387
query25	586	499	450	450
query26	1237	277	160	160
query27	2752	496	357	357
query28	4395	2177	2192	2177
query29	808	607	472	472
query30	297	229	200	200
query31	903	777	708	708
query32	85	71	75	71
query33	615	376	320	320
query34	787	855	516	516
query35	790	842	741	741
query36	948	982	880	880
query37	115	109	80	80
query38	3506	3511	3512	3511
query39	1460	1629	1406	1406
query40	219	125	117	117
query41	63	59	62	59
query42	132	114	113	113
query43	482	484	450	450
query44	1241	780	763	763
query45	181	180	171	171
query46	884	981	631	631
query47	1739	1839	1725	1725
query48	390	414	330	330
query49	805	498	420	420
query50	638	672	409	409
query51	3910	3862	3834	3834
query52	106	111	111	111
query53	239	270	197	197
query54	306	293	306	293
query55	85	86	83	83
query56	307	321	314	314
query57	1176	1190	1125	1125
query58	282	279	276	276
query59	2469	2598	2418	2418
query60	351	358	343	343
query61	175	151	154	151
query62	827	725	639	639
query63	229	197	201	197
query64	4526	1129	868	868
query65	4040	3918	3931	3918
query66	1140	418	328	328
query67	15327	15049	14911	14911
query68	4621	970	651	651
query69	488	319	286	286
query70	1342	1250	1209	1209
query71	421	336	318	318
query72	6264	5168	5077	5077
query73	641	598	366	366
query74	8843	8912	8688	8688
query75	3322	3394	2760	2760
query76	3264	1136	726	726
query77	521	416	322	322
query78	9703	9731	8974	8974
query79	2093	860	605	605
query80	1472	578	513	513
query81	573	256	221	221
query82	410	159	133	133
query83	272	262	262	262
query84	260	109	98	98
query85	890	478	433	433
query86	417	319	290	290
query87	3749	3729	3563	3563
query88	2910	2270	2223	2223
query89	395	331	305	305
query90	1794	227	225	225
query91	169	163	134	134
query92	78	71	61	61
query93	1293	1037	702	702
query94	721	455	348	348
query95	405	322	314	314
query96	489	549	285	285
query97	2933	2942	2858	2858
query98	245	217	212	212
query99	1265	1411	1272	1272
Total cold run time: 270344 ms
Total hot run time: 187095 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.46 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e92bab51d5eb2436d0d036651189bfc06cab0245, data reload: false

query1	0.05	0.05	0.06
query2	0.10	0.05	0.05
query3	0.26	0.08	0.08
query4	1.60	0.11	0.11
query5	0.28	0.25	0.26
query6	1.16	0.66	0.64
query7	0.04	0.03	0.03
query8	0.06	0.04	0.05
query9	0.59	0.53	0.52
query10	0.58	0.57	0.57
query11	0.15	0.11	0.12
query12	0.15	0.12	0.12
query13	0.63	0.62	0.61
query14	1.01	1.01	1.00
query15	0.84	0.84	0.83
query16	0.38	0.38	0.40
query17	1.02	1.04	1.03
query18	0.21	0.19	0.20
query19	1.90	1.79	1.81
query20	0.05	0.01	0.01
query21	15.45	0.21	0.13
query22	5.01	0.08	0.05
query23	15.66	0.26	0.10
query24	2.97	0.37	0.72
query25	0.09	0.06	0.07
query26	0.15	0.14	0.14
query27	0.07	0.13	0.07
query28	4.74	1.14	0.92
query29	12.56	3.84	3.24
query30	0.29	0.14	0.11
query31	2.82	0.58	0.39
query32	3.23	0.57	0.48
query33	3.02	3.02	3.04
query34	15.89	5.18	4.55
query35	4.53	4.60	4.58
query36	0.68	0.50	0.49
query37	0.10	0.07	0.07
query38	0.07	0.03	0.03
query39	0.03	0.04	0.04
query40	0.17	0.15	0.13
query41	0.08	0.04	0.03
query42	0.04	0.02	0.03
query43	0.05	0.03	0.03
Total cold run time: 98.76 s
Total hot run time: 27.46 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

Copy link
Contributor

@lide-reed lide-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.x reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants