-
Notifications
You must be signed in to change notification settings - Fork 26.6k
Remove jdk9-compile profile from pom.xml #15755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zrlw
wants to merge
5
commits into
apache:3.3
Choose a base branch
from
zrlw:3.3-remove-jdk-compile-profile
base: 3.3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+195
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15755 +/- ##
=========================================
Coverage 60.72% 60.72%
- Complexity 11695 11708 +13
=========================================
Files 1938 1938
Lines 88637 88637
Branches 13380 13380
=========================================
+ Hits 53825 53828 +3
+ Misses 29288 29285 -3
Partials 5524 5524
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e3333f1 to
9a3e96c
Compare
9a3e96c to
fc46032
Compare
fc46032 to
1f76507
Compare
…ed to latest version or not
…r to be compatible with jdk8
1f76507 to
31feb7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
jdk9-compileprofile configuration from pom.xml. For now,Unsafewill be considered as nonexistent package if setmaven.compiler.release, no matter the release is set to 8 or not. see details at There are difference betweenmaven.compiler.releaseandmaven.compiler.targetduring compiling projects which usesun.misc.Unsafewith JDK17+ maven-compiler-plugin#990positionmethod ofjava.nio.Bufferinstead ofjava.nio.ByteBufferfor the sake of jdk8 compatibility sincepositionmethod had been moved fromjava.nio.Bufferto its subclassjava.nio.ByteBuffersince jdk9+.What is the purpose of the change?
The release configuration of
jdk9-compileprofile will cause trouble if we compile dubbo with jdk17+ and usesun.misc.Unsafelike this,Cause
sun.misc.Unsafehad been moved tojdk.unsupportedmodule since jdk9+, it could not be added if setmaven.compiler.releasesee details at https://docs.oracle.com/en/java/javase/25/docs/specs/man/javac.html#option-release
Checklist