Fix: Stabilize URLParam.hashCode() to prevent Non-Dex nondeterminism in URLTest.testHashcode
#15757
+7
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
This PR stabilizes
URLParam.hashCode()to eliminate Non-Dex flakiness in tests (notablyURLTest.hashCode).Root Cause
The previous implementation multiplied
hashCodeCacheby 31 for each map entry.Because iteration order over
EXTRA_PARAMS(aHashMap) is nondeterministic, the resulting hash code varied between runs, breaking consistency withequals()and causing nondeterministic test failures.Changes Made
VALUE,KEY, and ignoredTIMESTAMP_KEY.Verification
You can try running the following snippet of code from the dubbo repo root, on both pre-fix and post-fix code
The test should fail intermittently on the pre-fix version, but pass consistently across all seeds on the post-fix version.
NonDex run logs will be available under the
dubbo-common/.nondexdirectory.Checklist