Skip to content

Conversation

@flyforeverth
Copy link
Contributor

@flyforeverth flyforeverth commented Nov 17, 2025

What is the purpose of the change?

Fix the thread safety of consumerConfigurationListener in the RegistryDirectory class
relate to #15707

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

Copy link
Contributor

@RainYuY RainYuY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RainYuY RainYuY requested a review from zrlw November 17, 2025 15:34
@RainYuY
Copy link
Contributor

RainYuY commented Nov 17, 2025

@zrlw PTAL

Copy link
Contributor

@zrlw zrlw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.75%. Comparing base (f284fab) to head (751b938).
⚠️ Report is 1 commits behind head on 3.3.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15775      +/-   ##
============================================
- Coverage     60.76%   60.75%   -0.01%     
+ Complexity    11712    11700      -12     
============================================
  Files          1938     1938              
  Lines         88646    88646              
  Branches      13379    13379              
============================================
- Hits          53866    53859       -7     
- Misses        29257    29264       +7     
  Partials       5523     5523              
Flag Coverage Δ
integration-tests-java21 32.38% <100.00%> (-0.07%) ⬇️
integration-tests-java8 32.44% <100.00%> (+<0.01%) ⬆️
samples-tests-java21 32.00% <100.00%> (-0.04%) ⬇️
samples-tests-java8 29.69% <100.00%> (+0.09%) ⬆️
unit-tests-java11 59.06% <100.00%> (-0.02%) ⬇️
unit-tests-java17 58.54% <100.00%> (-0.01%) ⬇️
unit-tests-java21 58.55% <100.00%> (-0.02%) ⬇️
unit-tests-java25 58.49% <100.00%> (-0.01%) ⬇️
unit-tests-java8 59.05% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RainYuY RainYuY merged commit 58d7386 into apache:3.3 Nov 17, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants