Skip to content

Conversation

@Anshul-creator
Copy link
Contributor

@Anshul-creator Anshul-creator commented Nov 22, 2025

What is the purpose of the change?

This PR stabilizes several tests in ProtocolConfigTest that were intermittently failing under randomized execution orders (NonDex):

  • testOverrideEmptyConfig
  • testOverrideConfigByName
  • testOverrideConfigById
  • testCreateConfigFromPropsWithId
  • testCreateConfigFromPropsWithName
  • testCreateDefaultConfigFromProps

All of these tests trigger DubboBootstrap.initialize(), which unintentionally initializes the metrics subsystem. Because these tests do not depend on metrics, metrics initialization introduces nondeterministic failures unrelated to protocol configuration logic.

Root Cause

These failures are identical to previously fixed issues in:

Those earlier PRs addressed flakiness caused by Micrometer’s CompositeMeterRegistry being initialized during DubboBootstrap.initialize(), leading to intermittent ArrayIndexOutOfBoundsException under NonDex seeds.

ProtocolConfigTest suffers from the exact same root cause, and the same fix (inline disabling of metrics + SysProps isolation) resolves the issue.

Changes Made

  • Disabled the metrics subsystem at the beginning of each test
  • Cleared all system properties using SysProps.clear() in both @BeforeEach and @AfterEach.
  • Reset framework state using DubboBootstrap.reset() to avoid cross-test leakage

Verification

You can try running the following snippet of code from the dubbo repo root, on both pre-fix and post-fix code

./mvnw -q -pl dubbo-config/dubbo-config-api \
  edu.illinois:nondex-maven-plugin:2.2.1:nondex \
  -DnondexRuns=20

The tests should fail intermittently on the pre-fix version, but pass consistently across all seeds on the post-fix version.
NonDex run logs will be available under the dubbo-config/dubbo-config-api/.nondex directory.

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.77%. Comparing base (9b32dc1) to head (4d817a5).

Additional details and impacted files
@@            Coverage Diff            @@
##                3.3   #15789   +/-   ##
=========================================
  Coverage     60.76%   60.77%           
- Complexity    11698    11699    +1     
=========================================
  Files          1938     1938           
  Lines         88646    88646           
  Branches      13379    13379           
=========================================
+ Hits          53868    53875    +7     
+ Misses        29250    29247    -3     
+ Partials       5528     5524    -4     
Flag Coverage Δ
integration-tests-java21 32.38% <ø> (+0.01%) ⬆️
integration-tests-java8 32.44% <ø> (ø)
samples-tests-java21 32.05% <ø> (-0.01%) ⬇️
samples-tests-java8 29.70% <ø> (+<0.01%) ⬆️
unit-tests-java11 59.07% <ø> (-0.01%) ⬇️
unit-tests-java17 58.55% <ø> (+<0.01%) ⬆️
unit-tests-java21 58.56% <ø> (-0.01%) ⬇️
unit-tests-java25 58.52% <ø> (-0.01%) ⬇️
unit-tests-java8 59.07% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@zrlw zrlw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RainYuY RainYuY merged commit 539af26 into apache:3.3 Nov 26, 2025
33 checks passed
@Anshul-creator Anshul-creator deleted the fix-ProtocolConfigTest branch November 27, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants