Fix: Stabilize ProtocolConfigTest by Disabling Metrics Initialization and Ensuring Test Isolation
#15789
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
This PR stabilizes several tests in
ProtocolConfigTestthat were intermittently failing under randomized execution orders (NonDex):testOverrideEmptyConfigtestOverrideConfigByNametestOverrideConfigByIdtestCreateConfigFromPropsWithIdtestCreateConfigFromPropsWithNametestCreateDefaultConfigFromPropsAll of these tests trigger
DubboBootstrap.initialize(), which unintentionally initializes the metrics subsystem. Because these tests do not depend on metrics, metrics initialization introduces nondeterministic failures unrelated to protocol configuration logic.Root Cause
These failures are identical to previously fixed issues in:
ExporterSideConfigUrlTestby disabling metrics initialization during URL export #15778MethodConfigTestby disabling metrics initialization to avoid Micrometer nondeterminism #15782ServiceConfigTestby isolating system properties and cached state #15785Those earlier PRs addressed flakiness caused by Micrometer’s
CompositeMeterRegistrybeing initialized duringDubboBootstrap.initialize(), leading to intermittentArrayIndexOutOfBoundsExceptionunder NonDex seeds.ProtocolConfigTestsuffers from the exact same root cause, and the same fix (inline disabling of metrics + SysProps isolation) resolves the issue.Changes Made
SysProps.clear()in both@BeforeEachand@AfterEach.DubboBootstrap.reset()to avoid cross-test leakageVerification
You can try running the following snippet of code from the dubbo repo root, on both pre-fix and post-fix code
The tests should fail intermittently on the pre-fix version, but pass consistently across all seeds on the post-fix version.
NonDex run logs will be available under the
dubbo-config/dubbo-config-api/.nondexdirectory.Checklist