-
Notifications
You must be signed in to change notification settings - Fork 29
HDDS-13446. Replace goofys with mountpoint-s3 in ozone-docker-runner #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jojochuang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. But I would like to wait until the Ozone CSI is ready to migrate to goofys. Otherwise acceptance tests will fail.
Dockerfile
Outdated
| RUN set -eux ; \ | ||
| ARCH="$(arch)"; \ | ||
| case "${ARCH}" in \ | ||
| x86_64) arch='x86_64' ;; \ | ||
| aarch64) arch='arm64' ;; \ | ||
| *) echo "Unsupported architecture: ${ARCH}"; exit 1 ;; \ | ||
| esac; \ | ||
| curl -L -o /tmp/mount-s3.rpm "https://s3.amazonaws.com/mountpoint-s3-release/latest/${arch}/mount-s3.rpm"; \ | ||
| dnf install -y /tmp/mount-s3.rpm; \ | ||
| rm -f /tmp/mount-s3.rpm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest to use a fixed version instead of the latest version:
| RUN set -eux ; \ | |
| ARCH="$(arch)"; \ | |
| case "${ARCH}" in \ | |
| x86_64) arch='x86_64' ;; \ | |
| aarch64) arch='arm64' ;; \ | |
| *) echo "Unsupported architecture: ${ARCH}"; exit 1 ;; \ | |
| esac; \ | |
| curl -L -o /tmp/mount-s3.rpm "https://s3.amazonaws.com/mountpoint-s3-release/latest/${arch}/mount-s3.rpm"; \ | |
| dnf install -y /tmp/mount-s3.rpm; \ | |
| rm -f /tmp/mount-s3.rpm | |
| RUN set -eux ; \ | |
| ARCH="$(arch)"; \ | |
| MOUNTPOINT_S3_VERSION="1.19.0"; \ | |
| case "${ARCH}" in \ | |
| x86_64) url="https://s3.amazonaws.com/mountpoint-s3-release/${MOUNTPOINT_S3_VERSION}/x86_64/mount-s3-${MOUNTPOINT_S3_VERSION}-x86_64.rpm" ;; \ | |
| aarch64) url="https://s3.amazonaws.com/mountpoint-s3-release/${MOUNTPOINT_S3_VERSION}/arm64/mount-s3-${MOUNTPOINT_S3_VERSION}-arm64.rpm" ;; \ | |
| *) echo "Unsupported architecture: ${ARCH}"; exit 1 ;; \ | |
| esac; \ | |
| curl -L ${url} -o mount-s3.rpm ; \ | |
| dnf install -y mount-s3.rpm ; \ | |
| rm -f mount-s3.rpm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jojochuang , it's a better solution.
I will modify it ASAP.
Dockerfile
Outdated
| x86_64) url="https://s3.amazonaws.com/mountpoint-s3-release/${MOUNTPOINT_S3_VERSION}/x86_64/mount-s3-${MOUNTPOINT_S3_VERSION}-x86_64.rpm" ;; \ | ||
| aarch64) url="https://s3.amazonaws.com/mountpoint-s3-release/${MOUNTPOINT_S3_VERSION}/arm64/mount-s3-${MOUNTPOINT_S3_VERSION}-arm64.rpm" ;; \ | ||
| *) echo "Unsupported architecture: ${ARCH}"; exit 1 ;; \ | ||
| esac; \ | ||
| curl -L ${url} -o mount-s3.rpm ; \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: please reduce duplication
| x86_64) url="https://s3.amazonaws.com/mountpoint-s3-release/${MOUNTPOINT_S3_VERSION}/x86_64/mount-s3-${MOUNTPOINT_S3_VERSION}-x86_64.rpm" ;; \ | |
| aarch64) url="https://s3.amazonaws.com/mountpoint-s3-release/${MOUNTPOINT_S3_VERSION}/arm64/mount-s3-${MOUNTPOINT_S3_VERSION}-arm64.rpm" ;; \ | |
| *) echo "Unsupported architecture: ${ARCH}"; exit 1 ;; \ | |
| esac; \ | |
| curl -L ${url} -o mount-s3.rpm ; \ | |
| x86_64) arch='x86_64' ;; \ | |
| aarch64) arch='arm64' ;; \ | |
| *) echo "Unsupported architecture: ${ARCH}"; exit 1 ;; \ | |
| esac; \ | |
| curl -L "https://s3.amazonaws.com/mountpoint-s3-release/${MOUNTPOINT_S3_VERSION}/${arch}/mount-s3-${MOUNTPOINT_S3_VERSION}-${arch}.rpm" -o mount-s3.rpm ; \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adoroszlai for reviewing the duplication issue.
|
Thanks @echonesis for the patch, @jojochuang for the review. |
What changes were proposed in this pull request?
Apache Ozone presently utilizes
goofysas its S3 FUSE implementation. Given that thegoofysrepository has been forked and is now under the maintenance of StatCan, our intention is to transition tomountpoint-s3, an AWS Labs-maintained package, for subsequent development efforts.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13446
How was this patch tested?
CI: https://github.com/echonesis/ozone-docker-runner/actions/runs/16337455101