[SPARK-54264][SS]DeDup Operator can use RocksDB's keyExists() #52960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@siying - can we also add some unit tests in |
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBSuite.scala
Outdated
Show resolved
Hide resolved
anishshri-db
approved these changes
Nov 11, 2025
Contributor
|
LGTM pending green CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a keyExists() function in StateStore. In RocksDB state store, it would use RocksDB's keyExists(), while by default, it will check whether get() to return any value. Change deduplication to use keyExists(), rather than get() to see whether the key exists in the state store.
Why are the changes needed?
Dedup operation now uses RocksDB's Get() only to check if there is result. Rather than doing that, it can use keyExists(), which serves the exact purpose but is faster.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing RocksDBStateStoreStreamingDeduplicationSuite should already cover this case.
Was this patch authored or co-authored using generative AI tooling?
No.