[SPARK-54282][BUILD] Read bom version from pom in SBT #52978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
reviewed
Nov 11, 2025
| } | ||
| } | ||
|
|
||
| // SparkBom can be removed once https://github.com/heremaps/here-sbt-bom/pull/47 is merged |
Member
There was a problem hiding this comment.
it's really nice! since this is not a blocker, maybe we can wait a few more days to have this upstream change get reviewed by the plugin authors
Member
Author
There was a problem hiding this comment.
I waited for heremaps/here-sbt-bom#47 to be reviewed and merged before moving forward with this PR. It will be good to have this PR merged as I have other changes pending this PR merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use pom file properties to read bom version from pom file and use it in SBT
Why are the changes needed?
To avoid redefinition of bom version in SBT build
Does this PR introduce any user-facing change?
No
How was this patch tested?
SBT build
Was this patch authored or co-authored using generative AI tooling?
No