Skip to content

Conversation

@hugozhu
Copy link

@hugozhu hugozhu commented Dec 27, 2024

issue 1:
when apisix-seed restart empty hosts might be returned, apisix may return 5xx during that peroid.

issue 2:
use 'labels' to tag route with nacos service discovery.
_discovery_type and _service_name is not compatible in 'upstream'

@CLAassistant
Copy link

CLAassistant commented Dec 27, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ hugozhu
❌ 一粟


一粟 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

hugozhu and others added 6 commits December 29, 2024 15:36
- Removed deprecated discovery attributes from test cases.
- Added a new test for marshaling routes with gRPC port support.
- Updated the Marshal function to correctly set the gRPC port for nodes in the route configuration.
feat: support service use grpc port
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants