Feedback from open incremental PRs #13010
Merged
+930
−340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1ac6272 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
phryneas
reviewed
Nov 13, 2025
| extensions: { | ||
| code: "INCREMENTAL_ERROR", | ||
| }, | ||
| path: ["foo", "bar"], |
Member
There was a problem hiding this comment.
Ohh, so errors come in with a complete path, not with a sub-path. I hadn't been aware of that - that makes this a lot easier to handle than I feared!
Member
Author
There was a problem hiding this comment.
Yep! Thankfully we don't have to concatenate paths at all 🙂
jerelmiller
force-pushed
the
release-4.1
branch
2 times, most recently
from
9aba88a to
2ad6c0d
Compare
jerelmiller
force-pushed
the
jerel/4.1-feedback
branch
from
aed023f to
08c016e
Compare
jerelmiller
force-pushed
the
jerel/4.1-feedback
branch
from
258f31f to
914591e
Compare
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 5 changed, 0 removedBuild ID: 66bc84a62e78aeebd96ce5c2 URL: https://www.apollographql.com/docs/deploy-preview/66bc84a62e78aeebd96ce5c2 |
jerelmiller
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses feedback from
@streamand incremental delivery PRs. Also addresses a few issues with the existing implementation. See changesets for more details on the fixed bugs.