feat(report): add fingerprint generation for vulnerabilities #9794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds unique fingerprint generation for detected vulnerabilities to enable external systems to track and deduplicate vulnerabilities across multiple scans. Key changes: - Add Fingerprint field to DetectedVulnerability type - Create pkg/fingerprint package with Fill() function - Fingerprint is SHA256 hash of: artifactID:target:pkgID:vulnerabilityID - Add CalcSHA256() function to pkg/digest for byte array hashing - Rename CalcSHA256 to CalcSHA256FromReader for clarity - Include comprehensive unit tests for fingerprint generation - Update integration test golden files with fingerprint values The fingerprint is deterministic, ensuring the same inputs always produce the same hash. This enables reliable tracking of vulnerabilities across scans even when other metadata may change. Future work will extend fingerprint generation to misconfigurations, secrets, and licenses using the same pattern. Closes aquasecurity#9793
This commit adds the "sha256:" prefix to fingerprint values for consistency with Docker/OCI digest standards. The fingerprint format is now "sha256:<64-char-hex>" instead of just the hex string. Changes: - Updated pkg/fingerprint to use digest.String() instead of Encoded() - Updated pkg/digest/digest.go to use hex.EncodeToString for better performance - Added nolint directives for placeholder functions - Updated all integration test golden files with new fingerprint format
knqyf263
added
kind/feature
github-actions
bot
added
the
apidiff
📊 API Changes DetectedSemver impact: |
Update the fingerprint length validation from 64 to 71 characters to account for the 'sha256:' prefix (7 characters) added to fingerprints.
Update spring4shell-jre8 and spring4shell-jre11 golden files to include the Fingerprint field with sha256 prefix for vulnerability CVE-2022-22965.
Add overrideFingerprint to TestSBOMEquivalence and TestTarWithOverride to clear fingerprints before comparison, as fingerprints vary between tests.
Signed-off-by: knqyf263 <[email protected]>
knqyf263
added
the
autoready
github-actions
bot
removed
the
autoready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements fingerprint generation for detected vulnerabilities to enable external systems to uniquely identify and track vulnerabilities across multiple scans.
Each vulnerability is assigned a deterministic SHA256-based fingerprint composed of:
The fingerprint format uses the "sha256:" prefix for consistency with Docker/OCI digest standards.
Related issues
Before and After
Before (without fingerprint)
{ "VulnerabilityID": "CVE-2023-42366", "PkgID": "[email protected]", "PkgName": "busybox", "InstalledVersion": "1.35.0-r17", "FixedVersion": "1.35.0-r18", "Status": "fixed", "PrimaryURL": "https://avd.aquasec.com/nvd/cve-2023-42366", "Title": "busybox: A heap-buffer-overflow", "Severity": "MEDIUM" }After (with fingerprint)
{ "VulnerabilityID": "CVE-2023-42366", "PkgID": "[email protected]", "PkgName": "busybox", "InstalledVersion": "1.35.0-r17", "FixedVersion": "1.35.0-r18", "Status": "fixed", "Fingerprint": "sha256:c2f054e07c516fabf395ddc7b362fbe43597bc2e1d80ac46d6043a0e67968efb", "PrimaryURL": "https://avd.aquasec.com/nvd/cve-2023-42366", "Title": "busybox: A heap-buffer-overflow", "Severity": "MEDIUM" }Checklist