[4.x] Add LogTenancyBootstrapper

[lukinovec]

This PR adds the LogTenancyBootstrapper to provide tenant-specific logging configuration. The bootstrapper automatically configures storage path channels to use tenant-specific directories (NOTE: for this to work correctly, the bootstrapper has to run AFTER FilesystemTenancyBootstrapper, otherwise, the logs still won't be separated, unless you use overrides) and supports custom channel overrides for custom logging scenarios (e.g. the slack channel, see the bootstrapper's comments).

Note that the bootstrapper first modifies the channel config, then forgets the channel so that on the next logging attempt, the channel is re-resolved with the modified config. Otherwise, the channel would just use the initial config (in most cases). When using a channel stack, the stack channel itself also has to be forgotten, since the LogManager could retain e.g. the original stack channel's webhook URL, while the underlying slack channel would use the updated one, and while logging, the app would actually use the initial webhook URL instead of the updated one -- encountered this very specific issue while testing).

Also, note: adding 'attachment' => 'false' to the slack channel's config makes the slack channel work with Discord webhooks (just a cool thing we figured out whlle testing the bootstrapper).

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.82%. Comparing base (aba7a50) to head (ae39e4d).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1381      +/-   ##
============================================
+ Coverage     85.36%   85.82%   +0.45%     
- Complexity     1128     1156      +28     
============================================
  Files           179      181       +2     
  Lines          3294     3400     +106     
============================================
+ Hits           2812     2918     +106     
  Misses          482      482              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull Request Overview

This PR adds a new LogTenancyBootstrapper to provide tenant-specific logging configuration. The bootstrapper automatically configures storage path channels to use tenant-specific directories and supports custom channel overrides for more complex logging scenarios.

Key changes:

• Implements LogTenancyBootstrapper with automatic storage path channel configuration and custom override support
• Adds comprehensive test coverage for default behavior, custom overrides, and real-world usage scenarios
• Registers the new bootstrapper in the test environment

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/Bootstrappers/LogTenancyBootstrapper.php	Main implementation of the log tenancy bootstrapper with storage path handling and channel override functionality
tests/Bootstrappers/LogTenancyBootstrapperTest.php	Comprehensive test suite covering default behavior, custom overrides, stack channels, and real logging scenarios
tests/TestCase.php	Adds import and singleton registration for the new bootstrapper in test environment

Comments suppressed due to low confidence (1)

tests/Bootstrappers/LogTenancyBootstrapperTest.php:345

• The test relies on catching exceptions to verify webhook URLs, but this approach is fragile and may not work reliably across different environments or Laravel versions. Consider mocking the HTTP client or using a more deterministic testing approach.

    try {

[Copilot]

The hardcoded filename 'laravel.log' should be made configurable or use the original filename from the channel configuration. This prevents customization of log filenames and could overwrite existing configurations.

Suggested change

	$this->config->set("logging.channels.{$channel}.path", storage_path('logs/laravel.log'));
	$logFilename = $this->getTenantLogFilename($tenant);
	$this->config->set("logging.channels.{$channel}.path", storage_path("logs/{$logFilename}"));

[lukinovec]

I don't think so, this is fine for the default behavior, it can still be customized. Resolving this

[stancl]

Out of the box, if no customization is used, $storagePathChannels includes daily which does not use laravel.log names, but day-specific names. Seems like something that should be checked and tested.

[lukinovec]

Since this is checked and tested already, I'd just add a short comment with an explanation of how daily works.

daily driver uses RotatingFileHandler that parses the file name. The current code (= storage_path('logs/laravel.log')) corresponds to the daily log channel config. It is correct, so I'd just clarify this since this can indeed be quite confusing

[stancl]

If the key in this array is e.g. slack, and we can provide either a "partial array override" or a closure that returns the override dynamically based on $tenant, why would the closure approach be:

function (Config\Repository $config, Tenant $tenant): void {
    $config->set('something', something based on $tenant);
}

As opposed to returning a value that'd directly override the channel:

function (array $channel, Tenant $tenant): array {
    return array_merge($channel, [overrides based on $tenant]);
}

The current approach would let you do for instance $channelOverrides['foo'] = fn ($config, $tenant) => $config->set('bar', ...) which doesn't make sense. And requiring the user to do $config->set() manually in the first place is unnecessary complexity for the user.

[lukinovec]

Should be resolved now f878aaf

[lukinovec]

Swapped the parameter order. Example for current usage of overrides:

LogTenancyBootstrapper::$channelOverrides = [
        'single' => function (Tenant $tenant, array $channel) {
            return array_merge($channel, ['path' => storage_path("logs/override-{$tenant->id}.log")]);
        },
];

Also updated the comments to clarify the bootstrapper's behavior. So I think this review can be resolved now