feat: add filter path support #199
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zach Aller <[email protected]>
zachaller
force-pushed
the
filtering-support-main
branch
from
57eb6fc to
9ad40dc
Compare
Signed-off-by: Zach Aller <[email protected]>
zachaller
force-pushed
the
filtering-support-main
branch
from
fc94634 to
417a74f
Compare
Signed-off-by: Zach Aller <[email protected]>
Signed-off-by: Zach Aller <[email protected]>
zachaller
force-pushed
the
filtering-support-main
branch
from
417a74f to
d7eee22
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #199 +/- ##
==========================================
+ Coverage 57.13% 57.16% +0.02%
==========================================
Files 11 11
Lines 1507 1508 +1
==========================================
+ Hits 861 862 +1
Misses 534 534
Partials 112 112 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Zach Aller <[email protected]>
Signed-off-by: Zach Aller <[email protected]>
Signed-off-by: Zach Aller <[email protected]>
Signed-off-by: Zach Aller <[email protected]>
Signed-off-by: Zach Aller <[email protected]>
Signed-off-by: Zach Aller <[email protected]>
Signed-off-by: Zach Aller <[email protected]>
zachaller
force-pushed
the
filtering-support-main
branch
from
e04828b to
b33d8fb
Compare
crenshaw-dev
requested changes
Feb 19, 2025
| ProposedCommitStatuses []CommitStatusSelector `json:"proposedCommitStatuses"` | ||
|
|
||
| // +kubebuilder:validation:Optional | ||
| OpenPullerRequestFilter *OpenPullerRequestFilter `json:"openPullRequestFilter,omitempty"` |
Contributor
There was a problem hiding this comment.
Maybe something like "relevantFilesFilter"?
Contributor
Author
There was a problem hiding this comment.
I think under this top level key, we would also include things like commitMessageFilters, commitUsers, etc etc
internal/git/git.go
Outdated
|
|
||
| for _, file := range diffOutput { | ||
| for _, pathPattern := range filter.Paths { | ||
| matched, err := filepath.Match(pathPattern, file) |
Contributor
There was a problem hiding this comment.
We should probably think about how we can mitigate directory traversal risks when applying glob patterns. Since we return a boolean, I think the only risk is path enumeration.
…promoter into filtering-support-main Signed-off-by: Zach Aller <[email protected]>
Signed-off-by: Zach Aller <[email protected]>
…filtering-support-main
Signed-off-by: Zach Aller <[email protected]>
Signed-off-by: Zach Aller <[email protected]>
Signed-off-by: Zach Aller <[email protected]>
…filtering-support-main Signed-off-by: Zach Aller <[email protected]>
This was referenced Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature adds a new field to the spec that lets users specific which files need to be changed from the output of a
git diff <environmentBranch> <environmentNextBranch> --name-only --diff-filter=ACMRTThis feature is good for mono repos where we only care about a particular sub directory grouping of application/environments