remote graph #1158
Open
remote graph #1158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-r-a-n-t
force-pushed
the
remote-graph
branch
3 times, most recently
from
586d478 to
8fb7a78
Compare
g-r-a-n-t
force-pushed
the
remote-graph
branch
from
deff46d to
5331856
Compare
Collaborator
|
Taking a look now! |
Collaborator
|
can you think of any obvious ways to break up tree.rs into a few smaller modules just to make it easier to navigate? not super important |
Collaborator
|
small thought on the graph struct: the |
g-r-a-n-t
force-pushed
the
remote-graph
branch
from
53df86e to
5447788
Compare
added 3 commits
December 1, 2025 15:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a Git-based node resolver and verified it by building a dependency graph from actual git repositories.
Added crates/resolver/src/git.rs:10-317, which introduces GitDependencyDescription, GitResource, and GitResolver. The resolver caches checkouts under a hashed directory, clones repositories with git2, checks out pinned revisions,
validates optional subdirectories, and exposes checkout diagnostics plus useful errors. (lib.rs now exports the module; see crates/resolver/src/lib.rs:1-4.)
Extended the resolver crate dependencies with git2, sha2, and the tempfile dev helper for creating/cleaning working clones in tests (crates/resolver/Cargo.toml:13-28).
Added crates/resolver/tests/git.rs:1-182, which spins up real git repositories on disk, uses GitResolver as the graph’s node resolver, and asserts that the resulting DiGraph matches the dependency tree described in each ingot’s
fe.toml.
Update the common config module to support git/remote dependencies
Implement git/remote node resolution handling in driver and the tree subcommand