-
Notifications
You must be signed in to change notification settings - Fork 371
Chore/bench touch unused deps #1021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
2398811
9010b4c
d838ed2
4e68195
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,4 +1,4 @@ | ||||||
| # bench-templates | ||||||
|
|
||||||
| **Warning!!!** This package does not implement any benchmarks, but exports templates and macros for benchmarking. | ||||||
| In order to benchmark arkworks, please run `cargo bench` inside [ark-curves](https://github.com/arkworks-rs/algebra/tree/master/curves). | ||||||
| In order to benchmark arkworks, please run `cargo bench` inside the curves directory. | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| use ark_ec as _; | ||
| use ark_std as _; | ||
| use criterion::{criterion_group, criterion_main, Criterion}; | ||
|
|
||
| fn bench_deps(c: &mut Criterion) { | ||
| let mut g = c.benchmark_group("deps_touch"); | ||
| let a: ark_ff::BigInt<1> = ark_ff::BigInt::from(123u64); | ||
| let _ = a; | ||
| let _ = ark_serialize::Compress::Yes; | ||
| g.bench_function("noop", |b| b.iter(|| ())); | ||
| g.finish(); | ||
| } | ||
|
Comment on lines
+5
to
+12
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is the purpose of this? |
||
|
|
||
| criterion_group!(benches, bench_deps); | ||
| criterion_main!(benches); | ||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,4 +1,4 @@ | ||||||
| # test-templates | ||||||
|
|
||||||
| **Warning!!!** This package does not implement any tests, but exports templates and macros for testing. | ||||||
| In order to test arkworks, please run `cargo test` inside [algebra](https://github.com/arkworks-rs/algebra). | ||||||
| In order to test arkworks, please run `cargo test` inside the algebra directory. | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be updated; can you check which version is the minimal one required?