Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion ff/src/biginteger/arithmetic.rs
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,8 @@ pub fn find_relaxed_naf(num: &[u64]) -> Vec<i8> {
let mut res = find_naf(num);

let len = res.len();
if res[len - 2] == 0 && res[len - 3] == -1 {
// Only apply optimization if we have at least 3 elements
if len >= 3 && res[len - 2] == 0 && res[len - 3] == -1 {
res[len - 3] = 1;
res[len - 2] = 1;
res.resize(len - 1, 0);
Expand Down Expand Up @@ -377,6 +378,24 @@ mod tests {
assert_eq!(vec.len(), 4);
}

#[test]
fn test_find_relaxed_naf_edge_cases() {
// Test with empty result (zero input)
let relaxed_naf = find_relaxed_naf(&[0u64]);
assert!(relaxed_naf.is_empty());

// Test with short sequences (length < 3)
let relaxed_naf = find_relaxed_naf(&[1u64]);
assert_eq!(relaxed_naf, vec![1]);

let relaxed_naf = find_relaxed_naf(&[2u64]);
assert_eq!(relaxed_naf, vec![0, 1]);

// Test with length exactly 3 - relaxed NAF applies optimization
let relaxed_naf = find_relaxed_naf(&[3u64]);
assert_eq!(relaxed_naf, vec![1, 1]);
}

#[test]
fn test_find_relaxed_naf_correctness() {
use ark_std::{One, UniformRand, Zero};
Expand Down
Loading