Skip to content

Try to fix macOS CI #2 #1415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 9, 2024
+10 −9
Merged

Try to fix macOS CI #2 #1415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cedaf57
ci(macos): add `--no-fail-fast` to `macos.yml`
arxanas Oct 9, 2024
4af668c
ci(macos): change condition for macOS CI job
arxanas Oct 9, 2024
898198a
ci(macos): disable tests on macOS for now
arxanas Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions .github/workflows/macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ env:

jobs:
run-tests:
if: startsWith(github.head_ref, 'ci-') || github.head_ref == ''
if: contains(github.head_ref, 'macos') || github.head_ref == ''
runs-on: macos-latest

steps:
Expand All @@ -36,10 +36,11 @@ jobs:
- name: Compile
run: cargo build --benches --tests

- name: Run tests
timeout-minutes: 30
run: |
export RUST_BACKTRACE=1
export TEST_GIT=$(which git)
export TEST_GIT_EXEC_PATH=$("$TEST_GIT" --exec-path)
cargo test --workspace
# TODO(#1416): re-enable once tests are passing on Git v2.46+
# - name: Run tests
# timeout-minutes: 30
# run: |
# export RUST_BACKTRACE=1
# export TEST_GIT=$(which git)
# export TEST_GIT_EXEC_PATH=$("$TEST_GIT" --exec-path)
# cargo test --workspace --no-fail-fast
2 changes: 1 addition & 1 deletion .github/workflows/windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
- name: Compile
run: cargo build --all-targets --workspace

# TODO: re-enable once tests are passing on Git v2.46+
# TODO(#1416): re-enable once tests are passing on Git v2.46+
# - name: Run tests
# timeout-minutes: 30
# run: |
Expand Down
Loading