Skip to content

[ty] Keep colorizing mypy_primer output #21515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2025
Merged

[ty] Keep colorizing mypy_primer output #21515

merged 1 commit into from
Nov 19, 2025
+2 −1

Conversation

@sharkdp
Copy link
Contributor

@sharkdp sharkdp commented Nov 18, 2025 •
edited
Loading

Summary

After an update to mypy_primer, we now need to set the environment variable ourselves.

@astral-sh-bot
Copy link

astral-sh-bot bot commented Nov 18, 2025

Diagnostic diff on typing conformance tests

No changes detected when running ty on typing conformance tests ✅

@astral-sh-bot
Copy link

astral-sh-bot bot commented Nov 18, 2025 •
edited
Loading

mypy_primer results

No ecosystem changes detected ✅

No memory usage changes detected ✅

@sharkdp sharkdp force-pushed the david/mypy_primer-strip-ansi-hyperlinks branch from ab16263 to c4a47d1 Compare November 18, 2025 19:22
@sharkdp sharkdp marked this pull request as ready for review November 18, 2025 19:28
@sharkdp sharkdp changed the title [ty] Strip hyperlinks from mypy_primer diffs [ty] Strip OSC 8 hyperlinks from mypy_primer diffs Nov 18, 2025
@sharkdp sharkdp added ci Related to internal CI tooling ty Multi-file analysis & type inference labels Nov 18, 2025
@astral-sh-bot
Copy link

astral-sh-bot bot commented Nov 18, 2025

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@AlexWaygood
Copy link
Member

AlexWaygood commented Nov 18, 2025 •
edited
Loading

Colorized output in the GitHub Actions terminal is still working

hmm, but it looks like the error code has now been stripped as well? 😄 It's now just error[] instead of error[invalid-await]

I don't mind too much if we just disable colour entirely for ty in mypy_primer. I do occasionally find colourised logs useful, but it's probably not worth spending a lot of time on right now :-)

@AlexWaygood
Copy link
Member

AlexWaygood commented Nov 18, 2025

hmm, but it looks like the error code has now been stripped as well?

oh, but I guess they're missing on the main branch too? E.g. https://github.com/astral-sh/ruff/actions/runs/19479467091/job/55747619369?pr=21467. I think that might have also regressed in #21502...

@sharkdp
Copy link
Contributor Author

sharkdp commented Nov 18, 2025

hmm, but it looks like the error code has now been stripped as well? 😄 It's now just error[] instead of error[invalid-await]

Oh, I didn't even notice in the screenshot. Well, that's not my fault. We show the unmodified output in the terminal. I guess the GitHub Actions ANSI parser can't handle hyperlinks?

I don't mind too much if we just disable colour entirely for ty in mypy_primer. I do occasionally find colourised logs useful, but it's probably not worth spending a lot of time on right now :-)

Ok, I guess I'll just change it

MichaReiser
MichaReiser approved these changes Nov 18, 2025
View reviewed changes
Copy link
Member

@MichaReiser MichaReiser left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't even notice in the screenshot. Well, that's not my fault. We show the unmodified output in the terminal. I guess the GitHub Actions ANSI parser can't handle hyperlinks?

Hmm. Terminals should skip unsupported ansi escaped without stripping the content.

We can also consider using a crate to dedect supported terminals so that our users can keep using color too. Happy to own that.

@MichaReiser
Copy link
Member

MichaReiser commented Nov 19, 2025 •
edited
Loading

Sorry for breaking mypy primer, I just published #21519

@sharkdp sharkdp force-pushed the david/mypy_primer-strip-ansi-hyperlinks branch from c4a47d1 to 8ffa4a8 Compare November 19, 2025 08:48
@sharkdp sharkdp changed the title [ty] Strip OSC 8 hyperlinks from mypy_primer diffs [ty] Keep colorizing mypy_primer output Nov 19, 2025
@sharkdp sharkdp enabled auto-merge (squash) November 19, 2025 08:52
@sharkdp
Copy link
Contributor Author

sharkdp commented Nov 19, 2025

I just published #21519

Thanks. No worries.

@sharkdp sharkdp merged commit e29f3ed into main Nov 19, 2025
38 checks passed
@sharkdp sharkdp deleted the david/mypy_primer-strip-ansi-hyperlinks branch November 19, 2025 08:52
dcreager added a commit that referenced this pull request Nov 19, 2025
@dcreager
Merge remote-tracking branch 'origin/main' into HEAD
81df564 
* origin/main:
  [ty] Fix flaky tests on macos (#21524)
  [ty] Add tests for generic implicit type aliases (#21522)
  [ty] Semantic tokens: consistently add the `DEFINITION` modifier (#21521)
  Only render hyperlinks for terminals known to support them (#21519)
  [ty] Keep colorizing `mypy_primer` output (#21515)
  [ty] Exit with `2` if there's any IO error (#21508)
  [`ruff`] Fix false positive for complex conversion specifiers in `logging-eager-conversion` (`RUF065`) (#21464)
  [ty] tighten up handling of subscripts in type expressions (#21503)
dcreager added a commit that referenced this pull request Nov 19, 2025
@dcreager
Merge remote-tracking branch 'origin/main' into dcreager/abnormal
7168ee8 
* origin/main:
  [ty] Fix flaky tests on macos (#21524)
  [ty] Add tests for generic implicit type aliases (#21522)
  [ty] Semantic tokens: consistently add the `DEFINITION` modifier (#21521)
  Only render hyperlinks for terminals known to support them (#21519)
  [ty] Keep colorizing `mypy_primer` output (#21515)
  [ty] Exit with `2` if there's any IO error (#21508)
  [`ruff`] Fix false positive for complex conversion specifiers in `logging-eager-conversion` (`RUF065`) (#21464)
  [ty] tighten up handling of subscripts in type expressions (#21503)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

Assignees

No one assigned

Labels

ci Related to internal CI tooling ty Multi-file analysis & type inference

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sharkdp @AlexWaygood @MichaReiser