-
Notifications
You must be signed in to change notification settings - Fork 1
Lparallel overhaul 2 #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ambrevar
wants to merge
42
commits into
master
Choose a base branch
from
lparallel-overhaul2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
4bb9700
.github/workflows/tests: Enable ECL tests.
Ambrevar cba51bd
package: Fix typo in *debug-on-error* docstring.
Ambrevar f7e959c
package: Add lpara nickname.
Ambrevar 945c7ca
Replace Calispel with Lparallel.
Ambrevar ae6c737
gitmodules: Remove Calispel.
Ambrevar fc0a2a1
prompter.asd: Remove Calispel.
Ambrevar ffab73e
tests: Move to Lparallel API.
Ambrevar 2bc0a42
README: Add Roadmap section.
Ambrevar 92ffdb8
Fix performance issue.
Ambrevar d69f18e
Fix missing documentation for attribute-value and attributes-values.
Ambrevar 2b2a404
Fix ECL support.
Ambrevar 99f7935
tests: Remove spurious extra destroy.
Ambrevar b83932f
Nullify kernels on destroy.
Ambrevar 08fb44c
tests: Clean up sources after use.
Ambrevar 3445883
tests: Destroy prompter even on error.
Ambrevar ba1de7c
tests: Increase timeout for slow ECL.
Ambrevar 95af8fa
tests: Fix error-handling test.
Ambrevar 2e1d708
Remove outdated comment.
Ambrevar 77d33f5
Re-allow interrupting prompters (with Lparallel this time).
Ambrevar 207f0b6
Use define-generic wherever possible.
Ambrevar 2212cd1
Simplify initial-suggestions assignment.
Ambrevar 9bc8663
Use etypecase instead of manual type check.
Ambrevar 32bff8c
Clarify comment on why we may need a new kernel for attributes.
Ambrevar eb17b97
Bind processed suggestion properly.
Ambrevar 66a3cc3
Fix result-channel type and docstring.
Ambrevar de9419c
Use return-from instead of manual block creation.
Ambrevar 240e5fa
Move source prompter setting from `make' to `initialize-instance :aft…
Ambrevar b587432
Add `kernel' reader for `source'.
Ambrevar ddc2661
tests: Remove obsolete thread management.
Ambrevar 3e66e98
Fix some docstrings and comments.
Ambrevar 235b350
Rename result-channel to `result' and add blocking accessor.
Ambrevar 2d9a6b6
Fix attributes-non-default docstring.
Ambrevar d59ee46
Support extraneous elements in attributes.
Ambrevar 95a7f32
Start computing attribute values immediately.
Ambrevar 10eb145
Use attribute-value in attribute-default.
Ambrevar eb15787
Add attribute-options and attributes-options.
Ambrevar 44d442e
Fix kill right kernel in source' `destroy'.
Ambrevar 9d53101
Fix-wait for interrupted result future.
Ambrevar 096d388
Export attribute-key and attributes-keys.
Ambrevar b4d5c7d
Fix ready-p documentation and remove writer.
Ambrevar 27dce4c
Replace update-notifier with update-hook.
Ambrevar e69eeec
gitmodules: Add nhooks.
Ambrevar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule calispel
deleted from
e9f2f9
Submodule cl-jpl-util
deleted from
0311ed
Submodule jpl-queues
deleted from
b774d2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change goes beyond the scope of the PR, so I'd kindly ask to remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR changes thread management and one of the important features is to do it properly. This could be highlighted by the tests initially not working properly on ECL and macOS. Hence the need to restore the matrix to a wider state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It must be acknowledged that you find that an alternative CI design amounts to higher quality standards. I'd suggest having that exchange elsewhere (for instance, an issue). I consider that this PR is not the right context.
The current design of the CI was the product of thoughtful joint discussions with @jmercouris. Seeing a change of strategy without prior notice or discussion and within another context seems to lack some cordiality. I think we all have a vested interested in respecting each other's perspectives and reaching an amenable outcome for all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ambrevar can you please put it in another, separate PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in #37.