JC-1877 adjust the create issue dialog header accordingly to the product changes #172
+12
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mblajet-atlassian
requested review from
jacek-foremski,
jreczyckiatatlassian and
mgrzaslewicz
mgrzaslewicz
previously approved these changes
May 19, 2025
Contributor
|
@mblajet-atlassian There is failure in github pipelines. Let's make gradle build more verbose |
…pipeline execution
Contributor
Author
@mgrzaslewicz There is a problem with the gradle itself. I can see that some builds were failing on master as well (but the logs has expired) This is probably caused by the old Gradle used here, as the version is 5.1.1 |
Contributor
|
@mblajet-atlassian I saw the error hence attempt to add verbosity flags. I can't reproduce it locally and currently we can't see why this error happen |
mblajet-atlassian
force-pushed
the
JC-1877-fix-create-issue-scenario
branch
2 times, most recently
from
6bef359 to
8c580a6
Compare
Contributor
Author
|
CI on master fails as well: https://github.com/atlassian/jira-actions/actions/runs/15114307698 |
Contributor
Author
|
The tests passed locally |
mgrzaslewicz
approved these changes
May 19, 2025
Contributor
|
Bumping gradle-release to 0.10.0 might help. |
dagguh
reviewed
May 19, 2025
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| - name: Set up Java 8 | ||
| uses: actions/setup-java@v3 |
Contributor
There was a problem hiding this comment.
This sets up JDK, but also generates some Maven files. And gradle-release touches those files, erroring out:
Maven settings contains encrypted credentials yet no settings-security.xml exists.
stacktrace
Caused by: java.lang.RuntimeException: Unable to decrypt local Maven settings credentials.
at net.linguica.gradle.maven.settings.LocalMavenSettingsLoader.decryptCredentials(LocalMavenSettingsLoader.java:102)
at net.linguica.gradle.maven.settings.LocalMavenSettingsLoader.loadSettings(LocalMavenSettingsLoader.java:66)
at com.atlassian.performance.tools.release.repositories.RepositoryConfigurator.mavenCredentials(RepositoryConfigurator.kt:92)
at com.atlassian.performance.tools.release.repositories.RepositoryConfigurator.findCredentials(RepositoryConfigurator.kt:74)
at com.atlassian.performance.tools.release.repositories.RepositoryConfigurator.access$findCredentials(RepositoryConfigurator.kt:11)
at com.atlassian.performance.tools.release.repositories.RepositoryConfigurator$atlassianRepository$1.execute(RepositoryConfigurator.kt:63)
at com.atlassian.performance.tools.release.repositories.RepositoryConfigurator$atlassianRepository$1.execute(RepositoryConfigurator.kt:11)
at org.gradle.api.internal.artifacts.DefaultArtifactRepositoryContainer.addRepository(DefaultArtifactRepositoryContainer.java:89)
at org.gradle.api.internal.artifacts.dsl.DefaultRepositoryHandler.maven(DefaultRepositoryHandler.java:102)
at com.atlassian.performance.tools.release.repositories.RepositoryConfigurator.atlassianRepository(RepositoryConfigurator.kt:61)
at com.atlassian.performance.tools.release.repositories.RepositoryConfigurator.access$atlassianRepository(RepositoryConfigurator.kt:11)
at com.atlassian.performance.tools.release.repositories.RepositoryConfigurator$configurePublicAtlassianRepositories$1.invoke(RepositoryConfigurator.kt:49)
at com.atlassian.performance.tools.release.repositories.RepositoryConfigurator$configurePublicAtlassianRepositories$1.invoke(RepositoryConfigurator.kt:11)
at org.gradle.kotlin.dsl.ProjectExtensionsKt.repositories(ProjectExtensions.kt:145)
at com.atlassian.performance.tools.release.repositories.RepositoryConfigurator.configurePublicAtlassianRepositories(RepositoryConfigurator.kt:40)
at com.atlassian.performance.tools.release.repositories.RepositoryConfigurator.configureAtlassianRepositories(RepositoryConfigurator.kt:18)
at com.atlassian.performance.tools.GradleRelease.apply(GradleRelease.kt:25)
at com.atlassian.performance.tools.GradleRelease.apply(GradleRelease.kt:19)
at org.gradle.api.internal.plugins.ImperativeOnlyPluginTarget.applyImperative(ImperativeOnlyPluginTarget.java:42)
at org.gradle.api.internal.plugins.RuleBasedPluginTarget.applyImperative(RuleBasedPluginTarget.java:50)
at org.gradle.api.internal.plugins.DefaultPluginManager.addPlugin(DefaultPluginManager.java:177)
at org.gradle.api.internal.plugins.DefaultPluginManager.access$300(DefaultPluginManager.java:51)
at org.gradle.api.internal.plugins.DefaultPluginManager$AddPluginBuildOperation.run(DefaultPluginManager.java:267)
at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:301)
at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:293)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:175)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:91)
at org.gradle.internal.operations.DelegatingBuildOperationExecutor.run(DelegatingBuildOperationExecutor.java:31)
at org.gradle.api.internal.plugins.DefaultPluginManager$2.execute(DefaultPluginManager.java:155)
at org.gradle.api.internal.plugins.DefaultPluginManager$2.execute(DefaultPluginManager.java:152)
at org.gradle.configuration.internal.DefaultUserCodeApplicationContext.apply(DefaultUserCodeApplicationContext.java:48)
at org.gradle.api.internal.plugins.DefaultPluginManager.doApply(DefaultPluginManager.java:152)
... 130 more
Caused by: java.lang.RuntimeException: Maven settings contains encrypted credentials yet no settings-security.xml exists.
at net.linguica.gradle.maven.settings.LocalMavenSettingsLoader.decryptCredentials(LocalMavenSettingsLoader.java:89)
... 161 more
Contributor
Author
Yeah, I tried it without success. I merged it so that I can release it locally and unblock the performance tests. In the meantime, I will investigate the pipeline failure. |
Contributor
|
@mblajet-atlassian maven settings need to be figured out anyway in order to release a version |
Contributor
|
You can release from local too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Jira 10.7.0, the header for the
Create Issuedialog has changed from<h2>to<h1>, according to the A11y guidelines.The
create issueaction was failing since 10.7.0, because it couldn't find the header to move out of the configuring fields dropdown. After the change, both the new<h1>header and the legacy<h2>are supported.