fix: add null check for challenge in captcha rendering #1541
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue in the
renderfunction ofcaptcha.jswhere the code did not handle cases when thechallengeobject was undefined.Previously, the function only checked for
challenge.required, which could cause runtime errors ifchallengeitself was undefined.The updated logic now safely checks for both
challengeexistence and therequiredproperty.Changes
renderPasswordlessCaptchato handle undefinedchallenge.challengeis missing.Testing
Type of Change