feat: Filter Selector chars by allowlist or blocklilst
#511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## pr/unicode-in-selectors #511 +/- ##
======================================================
Coverage 97% 98%
======================================================
Files 99 100 +1
Lines 3426 3480 +54
======================================================
+ Hits 3340 3406 +66
+ Misses 86 74 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
axunonb
force-pushed
the
pr/selector-whitelist
branch
from
d4c57eb to
8a598b1
Compare
|
axunonb
added a commit
that referenced
this pull request
Nov 11, 2025
* Allow Unicode characters in `Selector`s Resolves #454 * Refactor internal `ParserSettings` to use static or const members Refactored internal `ParserSettings` to convert instance-level properties and methods to static or const members. * feat: Filter `Selector` chars by allowlist or blocklilst (#511) * Change enum `FilterType` to `SelectorFilterType` Implement proposals from review: * SelectorFilterType.Alphanumeric: alphanumeric characters (upper and lower case), plus '_' and '-' * SelectorFilterType.VisualUnicodeChars: All Unicode characters are allowed in a selector, except 68 non-visual characters: Control Characters (U+0000–U+001F, U+007F), Format Characters (Category: Cf), Directional Formatting (Category: Cf), Invisible Separator, Common Combining Marks (Category: Mn), Whitespace Characters (non-glyph spacing). * Make `NonVisualUnicodeCharacters` read-only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Allowed
Selectorcharacters can be defined by an allow list or a block list.enum FilterType { Allowlist, Blocklist }WithBlocklistall Unicode characters are allowed, except those in the block list.Allowlistuses a list of characters that are allowed. The default characters are alphanumeric characters (upper and lower case), plus '_' and '-'.FilterType.Allowlistis the default and avoids breaking changes in the v3 major version.FilterType SelectorCharFiltertoParserSettingsclass CharSet. It represents a set of characters that supports efficient storage and lookup for both ASCII and non-ASCII characters. It is used in theParseras allow list or block list. The speed for parsingPlaceholdera decreases by ~25% compared to v3.2.0 to v3.6.1.Parserto useCharSetand handle the definedFilterTypeParserSettings: Re-order members, update internal properties to better align with classCharSet.Benchmark
Parser.ParseFormat("{SomePlaceholder1}{SomePlaceholder2}{SomePlaceholder3}{SomePlaceholder4}{SomePlaceholder5}");