Skip to content

Conversation

@JOJ0
Copy link
Member

@JOJ0 JOJ0 commented Nov 12, 2025

Fixes "none of the paths are importable" error that was accidentally introduced in 4260162

4260162#diff-e324b20657a7d6b43b8b7aeb5754b96774f5062294b5ba7f1e3062845e9e7044R1382-R1390

  • Documentation.
  • Changelog.
  • Tests.

@github-actions
Copy link

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

@JOJ0 JOJ0 force-pushed the fix_from_logfile branch 2 times, most recently from 7763034 to f833d0a Compare November 12, 2025 19:57
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 67.44%. Comparing base (e326aaf) to head (97bc0b3).
⚠️ Report is 3 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
beets/ui/commands/import_/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6161   +/-   ##
=======================================
  Coverage   67.44%   67.44%           
=======================================
  Files         136      136           
  Lines       18526    18526           
  Branches     3129     3129           
=======================================
  Hits        12494    12494           
  Misses       5369     5369           
  Partials      663      663           
Files with missing lines Coverage Δ
beets/ui/commands/import_/__init__.py 42.85% <0.00%> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JOJ0 added a commit that referenced this pull request Nov 12, 2025
@JOJ0 JOJ0 marked this pull request as ready for review November 12, 2025 21:09
@JOJ0 JOJ0 requested a review from a team as a code owner November 12, 2025 21:09
Copilot AI review requested due to automatic review settings November 12, 2025 21:09
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copilot finished reviewing on behalf of JOJ0 November 12, 2025 21:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a regression introduced in version 2.4.0 where the import command with --from-logfile incorrectly raised a "none of the paths are importable" error, even when valid paths existed in the logfile.

Key Changes

  • Corrected the variable check from paths to byte_paths in the import function to properly validate whether any importable paths remain after filtering

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
beets/ui/commands/import_/init.py Fixed bug by checking byte_paths instead of paths to determine if any valid import paths exist after processing logfile entries
docs/changelog.rst Added changelog entry documenting the bug fix for the 2.4.0 regression

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@semohr semohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@semohr semohr enabled auto-merge November 13, 2025 10:29
JOJ0 added 2 commits November 13, 2025 19:26
Fixes "none of the paths are importable" error with any valid import log
file that was accidentally introduced in commit 4260162
@semohr semohr merged commit 07445fd into master Nov 13, 2025
19 checks passed
@semohr semohr deleted the fix_from_logfile branch November 13, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants