-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix import --from-logfile #6161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
7763034 to
f833d0a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6161 +/- ##
=======================================
Coverage 67.44% 67.44%
=======================================
Files 136 136
Lines 18526 18526
Branches 3129 3129
=======================================
Hits 12494 12494
Misses 5369 5369
Partials 663 663
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a regression introduced in version 2.4.0 where the import command with --from-logfile incorrectly raised a "none of the paths are importable" error, even when valid paths existed in the logfile.
Key Changes
- Corrected the variable check from
pathstobyte_pathsin the import function to properly validate whether any importable paths remain after filtering
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| beets/ui/commands/import_/init.py | Fixed bug by checking byte_paths instead of paths to determine if any valid import paths exist after processing logfile entries |
| docs/changelog.rst | Added changelog entry documenting the bug fix for the 2.4.0 regression |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
semohr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
Fixes "none of the paths are importable" error with any valid import log file that was accidentally introduced in commit 4260162
05cde1f to
97bc0b3
Compare
Fixes "none of the paths are importable" error that was accidentally introduced in 4260162
4260162#diff-e324b20657a7d6b43b8b7aeb5754b96774f5062294b5ba7f1e3062845e9e7044R1382-R1390
Documentation.Tests.