Fix errors in macOS and windows runs #134
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+20
to
+21
| # l2=[0.08551397247817498], | ||
| # linf=[0.12087467695430498]) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| # l2=[0.08551397247817498], | |
| # linf=[0.12087467695430498]) | |
| # l2=[0.08551397247817498], | |
| # linf=[0.12087467695430498]) |
Comment on lines
+33
to
+34
| # l2=[0.008142380494734171], | ||
| # linf=[0.018687916234976898]) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| # l2=[0.008142380494734171], | |
| # linf=[0.018687916234976898]) | |
| # l2=[0.008142380494734171], | |
| # linf=[0.018687916234976898]) |
Comment on lines
+53
to
+54
| # l2=[0.5598148317954682], | ||
| # linf=[0.6301130236005371]) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| # l2=[0.5598148317954682], | |
| # linf=[0.6301130236005371]) | |
| # l2=[0.5598148317954682], | |
| # linf=[0.6301130236005371]) |
Comment on lines
+67
to
+68
| # l2=[0.5899077806567905], | ||
| # linf=[0.8972489222157533]) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| # l2=[0.5899077806567905], | |
| # linf=[0.8972489222157533]) | |
| # l2=[0.5899077806567905], | |
| # linf=[0.8972489222157533]) |
| stepsize_callback = StepsizeCallback(cfl = 0.5) | ||
|
|
||
| callbacks = CallbackSet(summary_callback, analysis_callback, alive_callback, | ||
| callbacks = CallbackSet(#=summary_callback, analysis_callback,=# alive_callback, |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| callbacks = CallbackSet(#=summary_callback, analysis_callback,=# alive_callback, | |
| callbacks = CallbackSet(alive_callback, #=summary_callback, analysis_callback,=# |
bennibolm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is also a problem in serial runs. It seems to be a problem in the save solution callback.
On Windows, the error occurs in t8_forest_write_vtk_ext.
Shortened message:
One problem could be in
get_cmesh_info!used insave_mesh_file. There are always used 2*ndims faces. Check, if examples with only quads/hex work.But after disabling this routine for FV schemes in 1216115, the errors still occur.
Things I learned:
rhs!(Tested by disablingsummay_callback(),solve())t_end=0(sincerhs!is still called)analysis_callbackseems to work properlystepsize_callbackseems to work properlysave_solution_callbackI just noticed those warnings even for die DG runs on mpi windows:
[t8] WARNING: Trying to use shared memory but intranode and internode communicators are not set. You should call t8_shmem_init before initializing a shared memory array.