fix gene-in-gsets table (sub-issue 1372) #1397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Confirmed. Screenshot before fix: |
Member
Author
|
Will be fixed in master (need to upmerge to devel). Solution: match best column (symbol or ortholog) to GMT matrix. Older pgx may have GMT as human ortholog, newer pgx should use native symbol
|
This was referenced Apr 29, 2025
ESCRI11
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sub-issue of issue #1372 : Geneset table not showing genesets
Issue: code is still matching on human ortholog (perhaps old way). In newer pgx, seneset are by organism's native symbols.