Skip to content

Conversation

@ESCRI11
Copy link
Contributor

@ESCRI11 ESCRI11 commented Nov 11, 2025

As discussed, retain the common samples when uploading multi omics data from pgx files.

@ESCRI11 ESCRI11 requested a review from zitoa November 11, 2025 12:33
@zitoa
Copy link
Contributor

zitoa commented Nov 11, 2025

if common_rows is NULL (or length==0) should we display alert and abort the session? @ESCRI11

@ESCRI11
Copy link
Contributor Author

ESCRI11 commented Nov 11, 2025

@zitoa that should be handled by the already placed checks on samples step -- let me double check

@ESCRI11
Copy link
Contributor Author

ESCRI11 commented Nov 11, 2025

@zitoa Even better, its already handled by existant code; we were checking samples match but not auto-loading them. so all good

@ivokwee
Copy link
Member

ivokwee commented Nov 11, 2025

For the moment this is fine. However in the future we want also to be able to handle not matched multi-omics datasets. But in that case we need maybe a different data structure.

@ESCRI11 ESCRI11 merged commit 05c2610 into devel Nov 11, 2025
@ESCRI11 ESCRI11 deleted the mo-samples-from-pgx branch November 11, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants