Fix compilation on systems with larger utsname field sizes #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Linux the sizes of the sysname and machine fields are 65 bytes and the target array is large enough to hold the result of the snprintf command. On platforms where the sizes of the fields are larger, e.g. GNY/Hurd where they are 1024 bytes, the results overflows. src/request.c:1105:57: error: ‘%s’ directive output may be truncated writing up to 2048 bytes into a region of size between 211 and 218 [-Werror=format-truncation=] This change does not change the size of the array on Linux: 126 + 65 + 65 = 256
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux the sizes of the sysname and machine fields are 65 bytes and the target array is large enough to hold the result of the snprintf command.
On platforms where the sizes of the fields are larger, e.g. GNY/Hurd where they are 1024 bytes, the results overflows.
This change does not change the size of the array on Linux: 126 + 65 + 65 = 256