fix: FileNotFoundException after application cache got cleared #1922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Author
|
@Gustl22 can you have a look? 🙏 |
Collaborator
|
Thank you for the contribution and sorry for the delay! |
Gustl22
reviewed
Jun 5, 2025
| if (!loadedFiles.containsKey(fileName) || | ||
| // the file can be removed from the cache, this | ||
| // can happen automatically when the storage is almost full | ||
| (!kIsWeb && !fileSystem.file(loadedFiles[fileName]).existsSync())) { |
Collaborator
There was a problem hiding this comment.
I would prefer to check also check for if defaultTargetPlatform == Platform.Android, if it's something that only occurs on android.
I would also prefer to use await exists to not block the thread.
Also do you have some reference (preferably of Android) we can add to the docs here?
Member
|
@krispypen are you planning on finishing up this PR? :) |
Author
Oh I missed the previous message, I'll update today! @spydon |
Author
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When an android device is low on storage, it can happen that the OS clears the cache of the app. In that case we get a FileNotFoundException when running an audio file for the 2nd time.
Checklist
fix:,feat:,refactor:,docs:,chore:,test:,ci:etc).///, where necessary.Breaking Change
Related Issues