invocation_error_card: reduce noise on user abort event #10507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sluongng
force-pushed
the
sluongng/denoise-invocation-error-card
branch
2 times, most recently
from
18750eb to
9eda895
Compare
When a user abort a build, our current error card would show: ``` Build aborted ERROR: user interrupted ERROR: //foo:bar: user interrupted ERROR: //baz/baa:fou: user interrupted ... ``` which can be noisy, especially when `experimental_cancel_concurrent_tests` was used when multiple test executions were cancelled in parallel. Reduce the noise by capturing only the first Aborted event with USER_INTERRUPTED reason. Also include TargetCompleted label to the error log. This means that we should only show ``` Build aborted ERROR: //first/canceled:target: user interrupted ``` from the targetCompleted event in this card.
sluongng
force-pushed
the
sluongng/denoise-invocation-error-card
branch
from
9eda895 to
cc5bdcc
Compare
bduffany
reviewed
Oct 21, 2025
Comment on lines
+192
to
+193
| // Capture the very first USER_INTERRUPTED aborted event and | ||
| // ignore other USER_INTERRUPTED events to reduce noise in the UI. |
Member
There was a problem hiding this comment.
Could we simplify this / make it less stateful by just ignoring the target-specific interrupted events? e.g. looking at the example from the PR description
ERROR: user interrupted
ERROR: //foo:bar: user interrupted
ERROR: //baz/baa:fou: user interrupted
would it make sense to just ignore events where the target label is nonempty and the abort reason is USER_INTERRUPTED?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user abort a build, our current error card would show:
which can be noisy, especially when
experimental_cancel_concurrent_testswas used when multiple testexecutions were cancelled in parallel.
Reduce the noise by ignoring the aborted events with USER_INTERRUPTED
reason. This means that we should only show
from the Finished event in this card.