Fix runfiles access via file resolver and static fs
#10663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tempoz
force-pushed
the
fix-runfiles-access
branch
from
75548fb to
9a8b7ca
Compare
bduffany
reviewed
Nov 10, 2025
Contributor
Author
|
This is a major pare-down of what ended up basically being a re-write of fileresolver that I did while trying to investigate/understand this problem, and it seems to be failing the integration tests that motivated a lot of the re-write, so I may have to do a more complicated fix, in which case I'll probably have to effectively close this PR and open a much larger one. |
fmeum
reviewed
Nov 11, 2025
Contributor
Author
|
We got it working, no re-write of fileresolver required, thank goodness. |
fmeum
approved these changes
Nov 11, 2025
Co-authored-by: Fabian Meumertzheim <[email protected]>
bduffany
approved these changes
Nov 12, 2025
iain-macdonald
added a commit
that referenced
this pull request
Nov 14, 2025
This reverts commit c6a777d.
iain-macdonald
added a commit
that referenced
this pull request
Nov 14, 2025
Reverts #10663 This makes the dev push fail because of ``` Error getting static FS from relPath: "../+_repo_rules+com_github_buildbuddy_io_buildbuddy/static/": sub +_repo_rules+com_github_buildbuddy_io_buildbuddy/../+_repo_rules+com_github_buildbuddy_io_buildbuddy/static/: invalid argument ```
Contributor
|
FYI this wasn't working in dev because of this error: I reverted it for now to unblock the dev push, but feel free to roll forward with a fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since upgrading to
MODULE.bazel, the bazel runfiles have an additional intervening subdirectory_mainbetween the runfiles root and the paths we use.This also fixes the related test, which was previously embedding the file we were trying to access via the runfiles.