Generalize bindings for futures #1409
Merged
+443
−234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As usage expands a bit beyond just this crate it can be useful to have mutability in the guts of the implementation. It's also easy enough to provide this everywhere so it's not much of a burden to plumb it around.
This commit is similar to bytecodealliance#1390 in that the goal is to enable external systems to use the Rust bindings here without requiring the exact shape of the vtable structure and such. This is, for example, intended to be useful when working on `wit-dylib`.
dicej
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is similar to #1390 in that the goal is to enable external
systems to use the Rust bindings here without requiring the exact shape
of the vtable structure and such. This is, for example, intended to be
useful when working on
wit-dylib.