Remove 'static constraint from block_on #108
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Factor out `spawn` into an unsafe helper `spawn_unchecked` where `block_on` can allow a non-static future and output to execute because dataflow ensures the Task does not outlive the future. Fixes #107
Contributor
Author
|
@yoshuawuyts is this API change a breaking one? It permits more programs to typecheck than previously, and shouldn't break any existing ones. |
pchickey
force-pushed
the
pch/block_on_without_static
branch
from
28def15 to
36171c5
Compare
pchickey
force-pushed
the
pch/block_on_without_static
branch
from
36171c5 to
49f2f68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factor out
spawninto an unsafe helperspawn_uncheckedwhereblock_oncan allow a non-static future and output to execute because dataflow ensures the Task does not outlive the future.Fixes #107