feat: Simplify worker boilerplate with common helper #129
+133
−234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new_samples/common/cadence.go with NewCadenceClient() helper that handles all gRPC/YARPC setup in one function call. Before: worker.go was ~100 lines with manual YARPC dispatcher setup After: worker.go is ~40 lines focused on workflow/activity registration Key changes: - common.NewCadenceClient() encapsulates all gRPC connection boilerplate - Removed explicit logger/scope setup (Cadence provides defaults) - Template updated to use the common helper This is a stepping stone toward moving NewGrpcClient() to cadence-client itself (per Nathanael's proposal in Slack). Signed-off-by: Diana Zawadzki <[email protected]>
zawadzkidiana
force-pushed
the
simplify-worker-boilerplate
branch
from
0a5ed51 to
2a3a80c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new_samples/common/cadence.go with NewCadenceClient() helper that handles all gRPC/YARPC setup in one function call.
Before: worker.go was ~100 lines with manual YARPC dispatcher setup
After: worker.go is ~40 lines focused on workflow/activity registration
Key changes:
This is a stepping stone toward moving NewGrpcClient() to cadence-client itself (per Nathanael's proposal in Slack).