SideNav should overlay Content in UIShell #1585
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
style. This revert back this change and add more consistencies with the `navStore` and classes.
metonym
reviewed
Dec 17, 2022
src/UIShell/Content.svelte
Outdated
| class:bx--content="{true}" | ||
| style="{unsetLeftMargin ? 'margin-left: 0' : ''}" | ||
| {...$$restProps} | ||
| style="{unsetLeftMargin ? 'margin-left: 0;' : ''} {$$restProps.style}" |
Collaborator
There was a problem hiding this comment.
I don't think that this should be changed since $$restProps.style will override the attribute.
Collaborator
|
When testing this locally, the side nav is not appearing when toggling the hamburger menu. It seems to retain the Repro
side-nav.mov |
Contributor
Author
|
You are right my logic and my approach for this problem was wrong. I changed my strategy and took the same approach as React. The main strategy is to take advantage of the |
when side nav was not present.
The text in the docs have more margins because they use grid so it have the double the margins needed.
`rail SideNav`.
metonym
force-pushed
the
master
branch
2 times, most recently
from
e7485c4 to
417102d
Compare
metonym
force-pushed
the
master
branch
3 times, most recently
from
234c1f9 to
e774974
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1463
The expended class should not be applied when the
sideNavis below the breaking point. I added thebx--sidenav-fixedclass instead, it seems to works perfectly.Edit :
This PR also fixes the hack ofbx--contentthat was set previously.Last commit make more consistencies with the
navStoreand revert themargin-left: 0hack with newstorevariables.