-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix(21066): visual bug on FluidDropdown when invalid prop is true #21077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(21066): visual bug on FluidDropdown when invalid prop is true #21077
Conversation
|
All contributors have signed the DCO. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
I have read the DCO document and I hereby sign the DCO. |
bba8e7d to
9d8024d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21077 +/- ##
=======================================
Coverage 92.60% 92.60%
=======================================
Files 515 515
Lines 38225 38225
Branches 5807 5807
=======================================
Hits 35397 35397
Misses 2679 2679
Partials 149 149
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7faab19 to
88ae6a0
Compare
|
@suniltc-ibm thank you very much for your contribution. We had a discussion earlier about this issue happening in Fluid and requested a design spec for the invalid/warning state. We now have an open issue for this #21114 In any case, looking at what we have available in Figma and comparing it with your contribution, I noticed that the icon positioning is not totally correct. I compared it with the Fluid ComboBox, for example, and noticed that when we remove the invalidText, the positioning issue mentioned occurs: With invalidText prop looks great: Before we continue here, I’d like to check with our design team. @alina-jacob / @laurenmrice do you think we could keep it as it is in Figma for now and just add "Error message goes here" as the default for invalidText? If needed, we can open another issue once the design spec is available and address it on the dev side. Or, we can wait for your feedback and I can help @suniltc-ibm with the implementation. |
|
@heloiselui I have an open issue here for this that will be worked on this sprint. We are going to detail out the design specs for fluid inputs in these cases. |
88ae6a0 to
ba9b5f0
Compare




Closes #21066
When invalid prop is sent on FluidDropdown - error icons are not aligned correctly
Changelog
Changed
Testing / Reviewing
Error icon should show within the input box
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
Updated documentation and storybook examplesWrote passing tests that cover this changeAddressed any impact on accessibility (a11y)Tested for cross-browser consistencyMore details can be found in the pull request guide