Skip to content

Revert Lean test implementation's validation comparison mode #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shaobo-he-aws wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Revert Lean test implementation's validation comparison mode #794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cedar-drt/src/lean_engine.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,6 @@ impl CedarTestImplementation for CedarLeanEngine {

/// `ValidationComparisonMode` that should be used for this `CedarTestImplementation`
fn validation_comparison_mode(&self) -> ValidationComparisonMode {
ValidationComparisonMode::AgreeOnAll
ValidationComparisonMode::AgreeOnValid
}
}
4 changes: 2 additions & 2 deletions cedar-drt/src/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ pub fn run_val_test(
compare_validation_results(
policies,
&schema,
custom_impl.validation_comparison_mode(),
ValidationComparisonMode::AgreeOnAll,
rust_res,
definitional_res,
);
Expand All @@ -176,7 +176,7 @@ pub fn run_level_val_test(
compare_validation_results(
policies,
&schema,
custom_impl.validation_comparison_mode(),
ValidationComparisonMode::AgreeOnAll,
rust_res,
definitional_res,
);
Expand Down